Skip to content

Fix/956 always show basemap title tooltip - #957

Merged
airikej merged 2 commits into
rcfrom
fix/956-always-show-basemap-title-tooltip
Oct 2, 2026
Merged

airikej merged 2 commits into
rcfrom
fix/956-always-show-basemap-title-tooltip

Conversation

@ukuroio

@ukuroio ukuroio commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • UI Improvements
    • Map options now show a tooltip with the title on hover, including disabled options. When additional tooltip text is available, it appears alongside the title.
    • Disabled options now dim their content without dimming the entire option. Hover and focus styling for selected and disabled options has also been refined.

@ukuroio ukuroio self-assigned this Oct 2, 2026
@coderabbitai

coderabbitai Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

🧰 Additional context used
📚 Code guidelines (1)
CLAUDE.md — auto-discovered

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: TEDI-Design-System/react/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: fe71be9f-a493-4835-ab1a-5f67135d83c5

📥 Commits

Reviewing files that changed from the base of the PR and between fec9780 and f9882b9.

📒 Files selected for processing (3)
  • src/community/components/map-components/base-map-selection/base-map-option.tsx
  • src/community/components/map-components/base-map-selection/base-map-selection.module.scss
  • src/community/components/map-components/base-map-selection/base-map-selection.spec.tsx

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Base map options now always show a title tooltip on hover, with optional tooltip text following the title. Selection styles changed for historical, disabled, and focus-visible states. Tests no longer rely on title-width measurements or debounce-settling waits.

Changes

Base map options

Layer / File(s) Summary
Always show title tooltips
src/community/components/map-components/base-map-selection/base-map-option.tsx, src/community/components/map-components/base-map-selection/base-map-selection.spec.tsx
Removed title truncation measurement. Hover tooltips now show the title, followed by optional tooltip text. Tests cover title-only tooltips, disabled options, combined tooltip content, and keyboard interactions.
Selection state styling
src/community/components/map-components/base-map-selection/base-map-selection.module.scss
Updated historical selection hover rules, disabled title and content styling, and focus-visible outlines.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to f9882

Base map options now always show a title tooltip on hover, and the selection styling was adjusted. No concrete merge-blocking problem was found.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: always showing the basemap title tooltip.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

Warning

Some tools did not complete. Review the errors below.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown

♿ Accessibility — ✅ no blocking violations

No accessibility violations in the components changed by this PR.

⚠️ Pre-existing — 1 violation in components not changed here (warn only)

Component Rules Stories
TEDI-Ready/Components/Navigation/Tabs unknown 1
Stories

@ukuroio ukuroio linked an issue Oct 2, 2026 that may be closed by this pull request
@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown

🎨 Chromatic

No visual changes.

Built from f9882b9. Commits pushed after this are not covered; approve again to rebuild.

View the build

@airikej
airikej merged commit 6eef4b9 into rc Oct 2, 2026
27 of 29 checks passed
@airikej
airikej deleted the fix/956-always-show-basemap-title-tooltip branch October 2, 2026 09:18

This branch was successfully deployed

1 active deployment
github-pages — f9882b92 Deployed Oct 2, 2026 by ukuroio via Deploy #1808
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BaseMapSelection]: Title tooltip show conditions

4 participants