Skip to content

chore: rename theme switcher texts #742 - #743

Merged
airikej merged 1 commit into
rcfrom
chore/742-rename-storybook-theme-switcher-texts
Sep 29, 2026
Merged

airikej merged 1 commit into
rcfrom
chore/742-rename-storybook-theme-switcher-texts

Conversation

@airikej

@airikej airikej commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Style
    • Theme preview controls now label the default and dark themes as light and dark modes. Background choices are limited to Default, Inverted, and Brand; Muted, Subtle, Disabled, Black, and Inverted Contrast are no longer available.

@airikej airikej linked an issue Sep 29, 2026 that may be closed by this pull request
@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: TEDI-Design-System/angular/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 48f54809-c45b-4da1-93dd-ec728a311c57

📥 Commits

Reviewing files that changed from the base of the PR and between 329eb8e and 8b52252.

📒 Files selected for processing (1)
  • .storybook/preview.tsx

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The Storybook theme toolbar now labels the default and dark themes as light and dark modes. The background options are default, inverted, and brand; five other options were removed.

Changes

Storybook theme controls

Layer / File(s) Summary
Update theme toolbar options
.storybook/preview.tsx
The theme labels now identify light and dark modes. The background options retain default, inverted, and brand, and remove muted, subtle, disabled, black, and inverted-contrast.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: mart-sessman

Merge Risk: ⚪ Minimal · up to 8b522

The toolbar labels and available background choices change as intended. No actionable merge risk is evident from the supplied change context.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: renaming the Storybook theme switcher labels and options.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

♿ Accessibility — ✅ no blocking violations

No accessibility violations in the components changed by this PR.

🔕 Known issues — 19 stories marked todo (warn only)

Stories

@codecov

codecov Bot commented Sep 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions

Copy link
Copy Markdown

🎨 Chromatic

No visual changes.

Built from 8b52252. Commits pushed after this are not covered; approve again to rebuild.

View the build

@airikej
airikej merged commit e638799 into rc Sep 29, 2026
36 of 38 checks passed
@airikej
airikej deleted the chore/742-rename-storybook-theme-switcher-texts branch September 29, 2026 10:58

This branch was successfully deployed

1 active deployment
github-pages — 8b52252c Deployed Sep 29, 2026 by airikej via Deploy #1198
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename storybook theme switcher texts

2 participants