Skip to content

Restore call parameters when an abstract call fails #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mario4tier merged 2 commits into from
Oct 24, 2026
+4,427 −4,116
Merged

Restore call parameters when an abstract call fails #779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4d90c0
Restore call parameters when an abstract call fails
mario4tier Oct 23, 2026
e78f4a7
Regenerate talib/_ta_lib.c
mario4tier Oct 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 16 additions & 14 deletions talib/_abstract.pxi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,9 +289,10 @@ class Function(object):
local = self.__local
parameters = parameters or {}
parameters.update(kwargs)
for param, value in parameters.items():
if self.__check_opt_input_value(param, value):
local.opt_inputs[param]['value'] = value
updates = [(param, value) for param, value in parameters.items()
if self.__check_opt_input_value(param, value)]
for param, value in updates:
local.opt_inputs[param]['value'] = value
local.outputs_valid = False
local.info['parameters'] = self.parameters

Expand Down Expand Up @@ -459,18 +460,19 @@ class Function(object):
', '.join(input_price_series_names))
raise TypeError(msg)

self.set_function_args(*args, **kwargs)
self.__call_function()

# restore opt_input values to as they were before this call
for param_name, value in opt_input_values:
local.opt_inputs[param_name]['value'] = value
local.info['parameters'] = self.parameters
try:
self.set_function_args(*args, **kwargs)
self.__call_function()
finally:
# restore opt_input values to as they were before this call
for param_name, value in opt_input_values:
local.opt_inputs[param_name]['value'] = value
local.info['parameters'] = self.parameters

# restore input names values to as they were before this call
for input_name, value in price_series_name_values:
local.input_names[input_name]['price_series'] = value
local.info['input_names'][input_name] = value
# restore input names values to as they were before this call
for input_name, value in price_series_name_values:
local.input_names[input_name]['price_series'] = value
local.info['input_names'][input_name] = value

return self.outputs

Expand Down
Loading
Loading