Repository navigation
bot: commit short-stack study harnesses as one example target - #964
Merged
Merged
Conversation
The four harnesses now sit in crates/apps/bot/examples/vector_study/, one example target rooted at main.rs. Cargo builds each top-level examples/*.rs as its own target, and the three module files only build inside the tree. The tree type-checks and passes clippy -D warnings, with the stray test module removed and rustfmt applied. The study's other arms are dead code for this entry point, so the module carries one scoped allow(dead_code). The entry point refuses to run outside the frozen experiment copy. Generated-by: claude-code/claude-haiku-5-5 Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What generated this?
Generated-by: claude-code/claude-haiku-5-5
Motivation
The four offline harnesses for the short-stack paired study were uncommitted in a working tree, so the evidence trail behind Match short-stack response vectors between training and live play lived outside git. This puts them in the repository.
They did not build.
cargo checkon the examples failed with 68 errors. The modules were written as one tree rooted atvector_study.rs, but cargo builds each top-levelexamples/*.rsas its own target.This does not close the ticket above. It stays open until live replay records exist, so the description has no
Closesline.Solution
vector_study.rstocrates/apps/bot/examples/vector_study/main.rs, withstudy_sim.rs,study_paired.rsandstudy_result.rsbeside it. Cargo then builds one example target. NoCargo.tomlchange.#[cfg(test)] mod tests;instudy_sim.rs. No such file exists in the history.pub use paired::{...}, an unusedsim::Armimport, and two redundant path qualifiers.#[allow(dead_code)]onmod study_siminmain.rs, with a comment. The study's other arms are helpers this entry point does not call. The scoped allow covers 25 dead-code warnings. The alternative is deleting those helpers. That is a reviewer's call.neural-fixes/experiment, so it only runs against the frozen copy.No behaviour change. The harnesses are not part of any binary, and the bot and policy crates are untouched.
Not run: the harnesses were not executed. They type-check, pass
clippy -D warnings, and build in the workspace test step.Checklist
scripts/check.sh fullpasses on this exact commit. Output:Two timing-budget notices (docs check 228 s, whole gate 264 s, budget 120 s) are warnings, not failures.
This is one change: the harness move, one scoped allow and formatting.
Paired simulation: N/A, not a behaviour change.
Performance measurement: N/A, not a performance change.
Documents: none changed. The docs-name check passed inside the gate.
AI provenance:
Generated-by:is in the commit footer and in the section above.🤖 Generated with Claude Code