Enumerate all three TEST_CMD substitution sites in the Step 4 row - #151
Conversation
PR #121 added a third `{{TEST_CMD}}` occurrence to the template (the Phase 3 "Confirm the anchor actually executed tests" rule) without updating the Step 4 row, which still listed only the Phase 3 verify block and the Phase 8 rebase fence. Name the third site in the row, and add that rule to the list of test-naming passages Step 4 rewords when the repo has no test suite, so the shell-comment substitution does not land in prose that reads as an "executed-test count from" a comment. Closes #139 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Self-review rubric (posted as a plain comment; no independent reviewer is implied): Universal items
Repo-specific items
Out-of-diff observation: the Merge-readiness judgment: the Tests-fix FAIL is the structural no-test condition this repo's skill documents for prose changes, not missing regression coverage for a code fix; Behavioral validation is UNVERIFIED on a change that alters no generated-skill text for the common case. Both are stated in the PR body. This review was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
|
Merge-readiness re-assessment (continuation of an interrupted dispatch):
The PR is left open rather than merged. The skill's own merge bar is not met: the change edits A maintainer merge is expected to be low-risk: the diff changes no text a generated skill receives for repos with a test suite. This comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
Summary
TEST_CMDrow is corrected to enumerate all three places{{TEST_CMD}}appears in the template body. PR Require unique scratch filenames and define the structurally-red-anchor path #121 added a third occurrence (the Phase 3 "Confirm the anchor actually executed tests" rule,create-dev-loop.md:297) without revisiting the row, which still named only the Phase 3 verify block and the Phase 8 rebase fence.TEST_CMDis a shell comment would receive a rule reading "an executed-test count from# re-run the manual checklist" — the issue asked for the missing site to be checked against that clause.COMPILE_CMD("both places") has two occurrences,LINT_CMD("both") has two sites. OnlyTEST_CMDhad drifted.Closes #139
Research grounding
No
RESEARCH.mdfinding applies. This is a documentation-accuracy correction to the substitution table with no empirical claim behind it — the issue body says the same.Doc sync check
{{placeholder}}added or changed has a corresponding Step 4 substitution-table row — no placeholders were added or removed;python3 scripts/check_docs.pypasses.README.mdis unaffected (no Step was added, removed, or renamed). No finding is shipped, so noRESEARCH.mdentry is needed.Test plan
python3 scripts/check_docs.py— "Doc consistency check passed."python3 -m unittest discover -s tests -v— Ran 13 tests, OK/create-dev-loopbehavioral run — not performed. The change edits Step 4 instruction prose only (a parenthetical and a rewording list); it adds no placeholder, changes no template-body text, and touches no Step 3/5/6 path. The text a generated skill receives is unchanged for repos with a test suite, and for repos without one the change only widens which passages the generator is told to reword. Reviewers should treat the behavioral half as UNVERIFIED in the ordinary sense for this repo — the doc-consistency CI job covers mechanical parity only.Skipped issues (recorded per Phase 1)
The rest of the open backlog was deferred this cycle for the following reasons:
CLAUDE.md, which is harness-blocked in this loop and needs separate maintainer authorization (RESEARCH.md Implementations entries record a ship date that is unknowable when the entry is written #128 is additionally a convention choice for the maintainer).template-rule) — each proposes a new rule in the template body, which has no automated test and would need a real/create-dev-loopvalidation run this headless session cannot perform. A fully verifiable documentation-accuracy fix ranked higher on the Phase 2 tiebreaker.This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson