STAC-25360: drop the dead Artifactory env passthrough - #265
Merged
Conversation
ARTIFACTORY_PYPI_URL pointed at artifactory.tooling.stackstate.io's pypi-local index, one of the paths the package registry decommission has to come back empty on. Nothing reads it. It cannot be reached in any case: DOCKER_ENV is only used by the dev and omnibus targets, both of which depend on build, and build does `cd Dockerfiles/local_builder` -- a directory that does not exist in this repository. The whole local-builder flow has been broken for some time, so the credentials were being handed to an image that cannot be built. artifactory_user and artifactory_password go with it. They are generic Artifactory credentials in the same dead block, not specific to the Docker registry, so there is nothing left for them to authenticate. Deliberately untouched: .devcontainer/Dockerfile still bases on artifactory.tooling.stackstate.io/docker-virtual. That is the Artifactory Docker registry, a separate migration from GitLab packages to CodeArtifact. Not fixed here, but worth someone's attention: build, dev, omnibus and shell all reference Dockerfiles/local_builder or /local_init.sh and cannot work as written. Refs STAC-25360
viliakov
approved these changes
Aug 28, 2026
to not block unrelated PRs on a new CVE
This was referenced Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ARTIFACTORY_PYPI_URLpointed atartifactory.tooling.stackstate.io'spypi-localindex — one of the paths the GitLab-packages-to-CodeArtifact decommission has to come back empty on. Nothing reads it.It was unreachable anyway:
DOCKER_ENVis used only bydevandomnibus, both depend onbuild, andbuilddoescd Dockerfiles/local_builder— a directory that does not exist in this repo. So these credentials were being handed to an image that cannot be built.artifactory_user/artifactory_passwordgo with it: generic Artifactory credentials in the same dead block, with nothing left to authenticate.Deliberately untouched:
.devcontainer/Dockerfilestill bases onartifactory.tooling.stackstate.io/docker-virtual. That is the Artifactory Docker registry — a separate migration, not this one.Not fixed here, worth someone's attention:
build,dev,omnibusandshellall referenceDockerfiles/local_builderor/local_init.shand cannot work as written. Removing or repairing that flow is a bigger call than this cleanup.Jira: https://stackstate.atlassian.net/browse/STAC-25360