Fix raster plot segment - #4790
Draft
JoeZiminski wants to merge 8 commits into
Draft
JoeZiminski wants to merge 8 commits into
JoeZiminski wants to merge 8 commits into
Conversation
JoeZiminski
marked this pull request as draft
September 16, 2026 18:55
JoeZiminski
force-pushed
the
fix-raster-plot-segment
branch
from
September 16, 2026 19:26
8a9acf1 to
e1b6ca3
Compare
JoeZiminski
commented
Sep 16, 2026
| backend: str | None = None, | ||
| **backend_kwargs, | ||
| ): | ||
| if durations is not None and segment_start_stop_times is not None: |
Contributor
Author
There was a problem hiding this comment.
kept for backward compatibility but we should eventually deprecate durations? It's no longer used, just converted to the new segment_start_stop_times
JoeZiminski
force-pushed
the
fix-raster-plot-segment
branch
from
September 16, 2026 19:40
e322cac to
434d58e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP - this PR fixes wrong time for plot motion when t_start neq 0
before:
now:
before:
now:
segment-wise