Add shank thickness to the Neuropixels probe annotations - #467
Merged
alejoe91 merged 1 commit intoSep 15, 2026
Merged
Conversation
alejoe91
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Pinpoint developers asked for the shank thickness to draw probes in 3D (SpikeInterface/probeinterface_library#73). imec's probe features table already has
shank_thickness_umfor every part number, butbuild_neuropixels_probeonly uses the shank width and tip length to draw the contour and drops the thickness.This PR stores it as a
shank_thickness_umannotation, keeping imec's name and unit. Whether thickness should become a schema field for all manufacturers is discussed in #452.