Skip to content

Attributes should be on the Song object, not inside an attrs object #42

Description

@spilth

All other implementations of SongPro put the core attributes like title and author on the song object, but the Javascript library currently puts them under an attrs object. Additionally the README shows the non-attrs approach.

My preference is for the Javascript library to be consistent with all other libraries.

Expected:

let song = SongPro.parse(contents);

console.log(song.title);
console.log(song.artist);

Actual:

let song = SongPro.parse(contents);

console.log(song.attrs.title);
console.log(song.attrs.artist);

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions