Repository navigation
fix(language-server): use theme graph for document links - #1355
Open
efegokdemir wants to merge 2 commits into
Open
efegokdemir wants to merge 2 commits into
efegokdemir wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
Fixes #968. Document links now use theme graph references, adding links for schema block types and custom elements while retaining existing Liquid links. The special
@themeblock type is excluded to avoid ambiguous multi-target links.What's next? Any followup issues?
None identified.
What did you learn?
The theme graph already records the source ranges needed for these links, so the language server can use the same references instead of maintaining a separate Liquid parser.
Tophatting
The new regression failed against the previous implementation, which returned no links for schema blocks or custom elements. The targeted package suite passed (77 files, 658 tests; 1 skipped), as did the language-server type-check and build, source formatting check and changeset validation.
Before you deploy
changeset