Repository navigation
Make the runbook scroll story shorter and let it play on its own - #702
Merged
Merged
Conversation
The pinned runbook needed about 3.5 screens of scrolling before all five rows were lit, and stayed on row 1 until the visitor kept scrolling. On a phone that reads as the page being stuck loading. Shorten the scroll track (intro 150vh to 120vh, pin 340vh to 250vh) and advance the rows on a timer once the stage is on screen. Scrolling still wins when the visitor is ahead of the timer. Thanks, Gerard
Gemini PR ReviewReviewed commit:
This result blocks merge. Push a fix and comment |
Collaborator
Author
|
/gemini review The pending tick is now cleared whenever the stage is off screen, so it cannot advance the rows while nobody is looking at them. Story tests pass on Chromium, WebKit, Firefox, mobile Chrome and mobile Safari. Thanks, |
Gemini PR ReviewReviewed commit: There are no actionable findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the homepage, the pinned db-maintenance runbook is driven only by scrolling. A visitor needed about 3.5 screens of scrolling to light all five rows, and if they stopped, it stayed on row 1. On a phone that reads as the page being stuck loading.
This shortens the scroll track and lets the rows play on a timer once the stage is on screen. Scrolling still wins whenever the visitor is ahead of the timer. Reduced-motion visitors are unchanged and still get the finished story.
Measured on a local build with Chromium, from the start of the story to all five rows lit:
For the rest of the page I measured the live site with a cold cache on throttled 4G and a 4x CPU slowdown: loaded in about 1.7 s, 52 KB transferred, no layout shift, no long tasks while scrolling, and the engine active at about 10 s. I found nothing else on the homepage worth changing, so this PR only touches the story.
Tests: one new test (rows play without scrolling). Homepage, sound, animation, accessibility and hero tests pass on Chromium, WebKit, Firefox, mobile Chrome and mobile Safari (330 passed).
Not checked: real devices. The numbers above are synthetic.
Thanks,
Gerard