Skip to content

Fix agent run count and SIMD label on the site - #614

Merged
gerardrecinto merged 2 commits into
masterfrom
site-copy-fixes
Oct 23, 2026
Merged

gerardrecinto merged 2 commits into
masterfrom
site-copy-fixes

Conversation

@gerardrecinto

Copy link
Copy Markdown
Collaborator

The site said five runs where Opus or Sonnet was allowed to run the other steps. docs/AGENT_BARRIER_TESTS.md has six authorized runs: five finished, and in one Claude Code's own safety check stopped a malformed call. The copy now says that.

The vector search label said SIMD, but DotProduct in ai/memory/math.go is a scalar loop. Removed the word from demo/index.html and demo/main.go.

Copy only. No behavior change.

@github-actions

Copy link
Copy Markdown

Gemini PR Review

Reviewed commit: 6eabde655068703b63392c79442b801bfb24c20d
Verdict: PASS

@github-actions

Copy link
Copy Markdown

Gemini PR Review

Reviewed commit: cdbffdc76c502dbaea3134370c0287a62490563b
Verdict: FAIL

  • demo/main.go, demo/index.html: The descriptive text for the vector search engine metric is changed from including "SIMD" (e.g., "Client-Side SIMD/WASM Dot-Product") to omitting it ("Client-Side WASM Dot-Product"). If the underlying WASM implementation for vector operations still utilizes SIMD instructions, this change could make the description less precise or potentially inaccurate. Confirm that the change in description correctly reflects the current implementation details (e.g., SIMD is no longer used, or its usage is not guaranteed/significant enough to be mentioned) to avoid a correctness bug in the metadata.

This result blocks merge. Push a fix and comment /gemini review. To contest a finding, see the Gemini dispute process in CONTRIBUTING.md.

@gerardrecinto

Copy link
Copy Markdown
Collaborator Author

/gemini dispute

  1. Finding: "The descriptive text for the vector search engine metric is changed from including "SIMD" ... to omitting it. If the underlying WASM implementation for vector operations still utilizes SIMD instructions, this change could make the description less precise or potentially inaccurate."
  2. Reference: EngineMetric in demo/main.go (line 486) and the matching label in demo/index.html; the function the label describes is DotProduct in ai/memory/math.go (line 61).
  3. Claim status: Inferred. The finding is conditional ("if ... still utilizes SIMD").
  4. Evidence: DotProduct is a scalar loop: for i := range a { dot += a[i] * b[i] }. There is no assembly file in ai/memory and no SIMD intrinsic or GOWASM setting anywhere in the Go sources or workflows (grep -i simd finds only a CI comment saying the CI avoids SIMD intrinsics). The old "SIMD" label therefore overstated the implementation, which is the correction this PR makes.
  5. Docs: none needed.
  6. Reachability: a label only, no behavior change.
  7. Tests: the existing site tests pass on this branch except for the Windows file-lock flake fixed in Fix the Windows unit test step failing on the daemon orphan test #621.
  8. Compensating control: none needed.
  9. Requested resolution: mark the finding not applicable on the current commit.

Thanks,
Gerard Recinto

@gerardrecinto

Copy link
Copy Markdown
Collaborator Author

/gemini review

@github-actions

Copy link
Copy Markdown

Gemini PR Review

Reviewed commit: cdbffdc76c502dbaea3134370c0287a62490563b
Verdict: PASS

  • Withdrawn Finding: demo/main.go (line 486), demo/index.html (line 1492) - Description of vector search engine metric.
    The finding stated that removing "SIMD" from the description might make it less precise if SIMD instructions were still used. The dispute provided evidence that the underlying DotProduct implementation in ai/memory/math.go is a scalar loop and does not utilize SIMD. Therefore, the prior description was an overstatement, and its removal makes the description more accurate. This change corrects a factual inaccuracy in the display text rather than introducing one.

@gerardrecinto
gerardrecinto merged commit ce80fb4 into master Oct 23, 2026
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant