Repository navigation
Publish to NuGet.org with trusted publishing (release-4.2) - #271
Merged
Merged
Conversation
Get a short-lived API key from NuGet.org through GitHub's OIDC token instead of using the long-lived NUGET_API_KEY secret. (cherry picked from commit b913127)
The tag filters only matched single-digit majors and stable patches, so tags such as 4.2.10 or 10.0.0 published nothing. The stable tag check was unanchored and unescaped, so a pre-release tag ending in three numbers, such as 1.0.0-alpha.1.2.3, would have been published to NuGet.org as stable. (cherry picked from commit beb237e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #267 and #269 to
release-4.2, cherry-picked with-x, so stable releases tagged on this branch can publish:NUGET_API_KEYno longer exists, so a stable tag can't publish without this. It uses the same nuget.org policy andNUGET_USERsecret.