Skip to content

fix(access): skip page checks without an HTTP request - #11

Merged
Seiger merged 1 commit into
Seiger:masterfrom
MiddleSokilAI:sokil/fix-api-resource-access
Oct 28, 2026
Merged

Seiger merged 1 commit into
Seiger:masterfrom
MiddleSokilAI:sokil/fix-api-resource-access

Conversation

@MiddleSokilAI

Copy link
Copy Markdown
Contributor

Problem and changes

Manager API entrypoints such as CAPTCHA bootstrap without binding an HTTP request. The OnWebPageInit resource-access listener nevertheless checks a page identifier against the current domain and can send the API request to the error page.

Skip that page-access listener only when the container has no request binding. Normal HTTP requests keep the existing domain-resource authorization and SSO exclusions.

Target and landing surfaces

Targets master, matching the installed package line. Only the plugin listener and a focused runtime regression test change. No project-specific domain configuration or profiling is included.

Verification

  • New regression test passes on PHP 8.4 and 8.5: request-less API bootstrap, denied HTTP page, and permitted HTTP page.
  • All existing domain-cache runtime checks pass on PHP 8.4.
  • Existing database-backed tests cannot run locally on PHP 8.5 because pdo_sqlite is missing; CI provisions SQLite for both PHP versions.
  • git diff --check passes.

Remaining validation

Dev browser verification after synchronization is pending. This PR remains a draft until that check and CI complete. sArticles has a companion request-less OnPageNotFound guard to protect its own API path independently.

@Seiger
Seiger marked this pull request as ready for review October 28, 2026 16:22
@Seiger
Seiger merged commit bfaad4a into Seiger:master Oct 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants