Skip to content

The Sinai Opt-In close read - #11

Merged
EliezerIsrael merged 2 commits into
mainfrom
claude/ceo-source-sheet-narrative-408e9e
Oct 12, 2026
Merged

EliezerIsrael merged 2 commits into
mainfrom
claude/ceo-source-sheet-narrative-408e9e

Conversation

@EliezerIsrael

Copy link
Copy Markdown
Member

Turns Alexander Luxenberg's source sheet The Sinai Opt-In into a close read: ?sheet=sinai-opt-in.

What's in it

  • Ten sections, using the sheet's headers in its order: Jacob's deathbed → Sinai → Golden Calf → Joshua → Joseph's bones → Josiah → de Wette → Ezra/Nehemiah → Esther + Shabbat 88a → Frankl and the Shema.
  • The pinned verses and commentary use the sheet's own texts and translations, including its ה'/אלקים spelling. The blasphemer and Rambam section is left out.
  • Word highlights trace the echoes between the texts:
    • the root א-ס-ף ("gather") across the gatherings;
    • "we will do" at Sinai against "make us" at the Calf;
    • Joseph and Joshua both dying at 110;
    • Exodus 24:7 next to II Kings 23:2, where a leader reads the covenant scroll to the people.
  • Two verses not on the sheet are added: Joshua 24:1 (the gathering at Shechem) and Deuteronomy 12:1 (the verse the sheet's de Wette note quotes).
  • All narration and question cards are new.

For review

  • The narration is new writing over the CEO's sheet, so it needs a read before he sees it.
  • Ezra 10:3, the covenant to expel foreign wives, is shown with one neutral question card.
  • The Frankl quote is shortened to a brief excerpt plus a paraphrase.
  • The Hebrew spelling of the author's name is a guess.

Tests

python3 -m pytest passes: 137 passed, 2 xfailed.

🤖 Generated with Claude Code

Ten sections in the sheet's order, his sources and translations; blasphemer
section omitted. Adds Joshua 24:1 and Deuteronomy 12:1 as pinned verses, and
a comparison of Exodus 24:7 with II Kings 23:2.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@gitvelocity-reviewer

Copy link
Copy Markdown

📊 Code Quality Score: 13/100

Base 13 (S5 + A0 + I3 + R2 + Q3 + P0) x ESF 1.0 = 13

Category Score Factors
🔭 Scope 5/20 Two files change: a new 1,148-line data/sinai-opt-in.json and one added entry in data/index.json. No application code, route or component is touched.
🏗️ Architecture 0/20 No module boundary, dependency or schema changes. The file follows the existing close-read structure of sections, steps, primaryText.words and step types narration, verse-change, commentary and question, and adds a comparison-mode verse in josiah-vc-compare.
⚙️ Implementation 3/20 The work is authoring structured data: Hebrew and English verse text, per-verse words maps, and highlight arrays that reference those keys. All highlight keys resolve to the verse in scope. vayityatzvu and katorah are defined and never highlighted, and esther-stood discusses va-yityatzvu with no verse on screen.
⚠️ Risk 2/20 A malformed field would affect only the new close-read page and its row in the index. The heresy-dewette commentary step has a sourceLabel with only en, which could render blank if the page reads sourceLabel.he. Reverting means deleting one file and one index entry.
✅ Quality 3/15 No test or validator accompanies the PR. sourceUrl and sourceLabel attribute the original sheet 487913 to its author, and commentary steps carry ref values such as Pesachim 56a:7 and Rashi on Joshua 24:22:1. The two defects flagged in the review (the unused words keys and the English-only sourceLabel on heresy-dewette) show no check ran over the file's internal consistency.
🔒 Perf / Security 0/5 No performance or security work is present. Step text contains inline <i> and <b> markup that the renderer must treat as trusted content.

Was this score accurate? 👍 Yes · 👎 No

How this was scored →

Scored by GitVelocity · How are scores calculated?

…et-narrative-408e9e

# Conflicts:
#	data/index.json
@EliezerIsrael
EliezerIsrael merged commit a46fd4d into main Oct 12, 2026
1 check passed
@gitvelocity-reviewer

Copy link
Copy Markdown

📊 Code Quality Score: 17/100

Base 17 (S5 + A0 + I6 + R2 + Q4 + P0) x ESF 1.0 = 17

Category Score Factors
🔭 Scope 5/20 Two files change: the new data/sinai-opt-in.json and one added entry in data/index.json. The sheet has ten sections spanning Genesis through the siddur, but no code path or subsystem is touched.
🏗️ Architecture 0/20 No module, schema or dependency changes. The sheet reuses the existing step types narration, verse-change, commentary and question, including the mode: comparison layout with left and right verses in josiah-vc-compare.
⚙️ Implementation 6/20 The content is built from per-verse words maps whose keys are referenced by each step's highlight array. Repeated roots and phrases (heasfu, meah, vayikra, sefer) carry across verse changes. section-josiah adds side-tagged word keys such as vayikra-l and vayikra-r for the comparison view. No executable logic is added.
⚠️ Risk 2/20 The change is additive: a new JSON file and one more object in the data/index.json array. A malformed entry or a highlight id with no matching words key would break or blank this one sheet and the index listing, and deleting the file and entry reverses it.
✅ Quality 4/15 No test or validator accompanies the sheet. The file carries bilingual Hebrew and English text, a sourceUrl back to the original Sefaria sheet, and sourceLabel fields on each commentary step. Nothing in the diff checks that highlight ids resolve to words keys.
🔒 Perf / Security 0/5 No performance or security work is present. The change is static JSON with an external link in sourceUrl.

Was this score accurate? 👍 Yes · 👎 No

How this was scored →

Scored by GitVelocity · How are scores calculated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant