Repository navigation
fix(dashboard): no stray "null" beside Learning in the add sheet - #45
Merged
Merged
Conversation
With one language read, the bulk add controls passed a null child to replaceChildren, which wrote it out as the text "null". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Ayla Croft <dev@scriptkittyos.com> (cherry picked from commit 716044690bbe86b1d3a1754f3fdefc63948f3d32)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Ayla Croft <dev@scriptkittyos.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With one language read, the dashboard's Add words sheet showed "Learning Spanish › null".
extension/bulk/sheet.jspassed anullchild toreplaceChildren, which writes it out as the text "null". The optional "meanings in" control is now spread in only when it exists.Found while recording the launch film's product footage.
test/dom/dashboard.test.mjsnow checks that the bulk controls read exactly "LearningSpanish". It fails without the fix (actual: 'LearningSpanishnull') and passes with it.npm test: 2083 pass, 0 fail.🤖 Generated with Claude Code