Repository navigation
fix(extension): the Spanish translation has the store name Chrome requires - #43
Merged
Merged
Conversation
…uires The Chrome Web Store refused v1.0.0's zip: "The translation of the name of your item is missing in locale es". _locales/es had extName and extDescription but not extStoreName, which the manifest's name uses, and the store requires every message the manifest names in every locale a package includes. The Spanish store name is now "Kotiko: aprende idiomas mientras navegas" (40 characters). A new store-readiness test checks every shipped locale for every manifest message within the stores' limits; it failed on v1.0.0 with "es: extStoreName is missing". Also removes release-please's release-as 1.0.0 pin, now that 1.0.0 is tagged, so this fix becomes 1.0.1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Ayla Croft <dev@scriptkittyos.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Chrome Web Store refused
kotiko-chrome-1.0.0.zipon the first upload with "The translation of the name of your item is missing in locale es".extension/_locales/es/messages.jsonhadextNameandextDescriptionbut notextStoreName, which the manifest'snameuses. The store requires every message the manifest names in every locale the package includes.__MSG_…__message the manifest uses, within the stores' limits. It fails on v1.0.0 withes: extStoreName is missingand passes now.release-as: 1.0.0pin, now that 1.0.0 is tagged, so thisfix:becomes 1.0.1.Lead check: a zip built from this branch contains the Spanish name;
npm testpasses 2083/2083; lint passes. The change touches no code, only a translation and a test. The security review stays closed for 1.0.x (review-v1.0.0.md).🤖 Generated with Claude Code