Repository navigation
fix: fixing a word's language no longer deletes it; docs say typed words reach Wiktionary (launch checks F1, F5) - #42
Merged
Conversation
…e answer is the same word
Launch check F1 on rc.4: "Another language" queues a new add that
replaces the old one, and once it's saved the old add is undone. When the
model answered with the same word in the same language ("Already in your
list"), the new add landed on the old add's word, and undoing the old add
deleted it: the word left the list for Recently deleted while the popup
said it was already there. Retiring the old add now keeps any word the new
one landed on. A regression test re-adds a word as itself: before, the
list was empty; now the word stays. The existing test (a real change of
language removes the old word) still passes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Ayla Croft <dev@scriptkittyos.com>
Launch check F5: the docs site and the README said nothing leaves your browser when you type 'word = meaning', but for a language with word stress Kotiko looks up the word on English Wiktionary for its pronunciation. The privacy policy already said so; now these pages do too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Ayla Croft <dev@scriptkittyos.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Ayla Croft <dev@scriptkittyos.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes from the automated launch checks on
v1.0.0-rc.4. Every main flow passed in Firefox and Chromium (20/20 each), using the release zips. These two are the findings worth fixing before the tag.retireReplacednow keeps any word the new add landed on. The regression test intest/bg/local-mode.test.mjsre-adds a word as itself: before the fix the list was[], after it["es:gato"]. The existing test (a real change of language removes the old word) still passes.word = meaning, but for a language with word stress Kotiko looks the word up on English Wiktionary for its pronunciation, as the privacy policy already says. Those pages now say so.check-security-gate.mjs --version 1.0.0.Filed for 1.0.x instead:
Checks:
npm test2082 pass; lint; sitenpm test25/25 andnpm run check; old-name; DCO.🤖 Generated with Claude Code