Skip to content

ci: run Checks against master, the branch this repo actually uses - #6

Merged
salmanfarisvp merged 1 commit into
masterfrom
ci/run-checks-on-master
Sep 25, 2026
Merged

salmanfarisvp merged 1 commit into
masterfrom
ci/run-checks-on-master

Conversation

@vpetersson-bot

Copy link
Copy Markdown
Contributor

Problem

.github/workflows/checks.yml triggers on development and main, but this repo's default branch is master. main is still the Initial commit it was created with (2026-09-17) and has never received a change, while master carries the real history and is what development merges into.

The result is that nothing targeting master is ever checked:

gh run list --workflow checks.yml confirms it: every run is either a push to development or a pull_request into development. Not one run has master as its base.

Fix

Point both the push and pull_request triggers at master instead of main. development keeps its trigger, so the feature-branch flow is unchanged — this only adds coverage on the branch the app is released from.

daylight-app is the only Edge App with this mismatch; every sibling repo's checks.yml already lists its own default branch.

🤖 Generated with Claude Code

The Checks workflow fires on development and main, but this repo's
default branch is master — main is still the "Initial commit" it was
created with and has never taken a change. So every pull request
targeting master merges without a single check having run: #4
(development -> master) and the open Dependabot bun group bump #5 both
show "no checks reported".

Point both triggers at master instead of main. development keeps its
trigger, so the feature-branch flow is unchanged; what this adds is
coverage on the branch the app is actually released from.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings September 24, 2026 08:20

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@salmanfarisvp
salmanfarisvp merged commit fb272e2 into master Sep 25, 2026
1 of 2 checks passed
@salmanfarisvp
salmanfarisvp deleted the ci/run-checks-on-master branch September 25, 2026 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants