Repository navigation
chore(deps): apply bun group update, hold TypeScript at 6.x - #16
Closed
vpetersson-bot wants to merge 1 commit into
Closed
vpetersson-bot wants to merge 1 commit into
vpetersson-bot wants to merge 1 commit into
Conversation
Dependabot's grouped bun update bumps TypeScript to 7.0.2, which breaks
`bun run lint`:
TypeError: undefined is not an object (evaluating 'ts.Extension.Cjs')
at @typescript-eslint/typescript-estree/dist/create-program/shared.js
`@screenly/edge-apps` lints via typescript-eslint 8.x, whose supported
TypeScript range is `>=4.8.4 <6.1.0`. TypeScript 7 is outside it, so the
ESLint TypeScript parser fails to load before any rule runs.
This applies every other dependency in the group and keeps TypeScript on
6.x, and adds a Dependabot `ignore` entry for `typescript >=7` so the
break is not reproposed each month. Drop that entry once typescript-eslint
declares TypeScript 7 support.
Verified locally: `bun run lint`, `type-check`, `test` and `build` all pass.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Member
|
@vpetersson-bot Fix the conflict. |
Contributor
Author
|
@salmanfarisvp There's nothing left to resolve here. Merging #5 put master in the same place this PR was going, and a bit further:
Rebasing would leave either an empty diff or a second This PR is redundant now and can be closed. |
Member
|
@vpetersson-bot This branch has conflicts that must be resolved before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependabot PR #5 fails CI. Its grouped bun update bumps TypeScript to
7.0.2, andbun run lintdies before linting anything:@screenly/edge-appslints through typescript-eslint 8.x, which declares its supported TypeScript range as>=4.8.4 <6.1.0. TypeScript 7 removed the internalts.Extension.Cjsthe parser reads at load time, so the failure is a hard load error, not a lint finding.What this does
ignoreentry fortypescript >=7so the same broken update is not reproposed every month.Remove the
ignoreentry and take TypeScript 7 once typescript-eslint declares support for it.Verification
bun run lint,bun run type-check,bun run testandbun run buildall pass locally on this branch.Supersedes #5.
🤖 Generated with Claude Code