Repository navigation
feat(analytics): add the GA4 tag - #5
Merged
Merged
Conversation
main.ts already calls the signage-kit `trackPlayer` with `sendPageView: true`, but index.html had no gtag.js, so it was a no-op and the app reported nothing. The tag is configured with `send_page_view: false`, matching the other static apps: `trackPlayer` sends the page view itself once the player is profiled, so the pair neither double-counts nor drops page views. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main.tsalready calls signage-kit'strackPlayer(..., { sendPageView: true }), butindex.htmlnever loaded gtag.js. Because of that,trackPlayerdid nothing and the app sent no analytics.This adds the GA4 tag to the top of
<head>, configured withsend_page_view: falselike the other static apps (e.g. word-of-the-day).trackPlayersends the page view itself once the player is profiled, so page views are counted exactly once and carry the player fields. The now-stale "No-op until a GA tag is added" comment is removed.Verified locally:
bun run lint,typecheck,bun testandbun run buildpass, anddist/index.htmlcontains the tag.Dependabot was already configured (
.github/dependabot.yml, identical to word-of-the-day), so nothing changes there.🤖 Generated with Claude Code