Remove retired relay provenance - #1
Merged
Merged
Conversation
审查者指南该 PR 通过将 macOS 捕获器的 Rust/Swift FFI ABI 及相关标识符重命名为 SciLaxy 所有的名称，移除了已废弃的来源标识；更新捕获器文档以准确描述 HEVC 输出；并将冒烟测试工具中的 XYZEN 环境变量和服务标签迁移为 SCILAXY 对应项。 使用重命名后的 FFI 进行 HEVC 捕获的时序图sequenceDiagram
participant Rust as Rust capturer
participant Swift as Swift MacCapturer
participant WS as Stream publisher
Rust->>Swift: scilaxy_capturer_start(width, height, fps, bitrateKbps, displayId, ctx, cb)
Swift-->>Rust: HEVC NAL callback
Rust->>WS: Send HEVC NAL binary frame
文件级变更
提示和命令与 Sourcery 交互
自定义你的使用体验访问你的控制面板，以便：
获取帮助Original review guide in EnglishReviewer's GuideThe PR removes retired provenance by renaming the macOS capturer’s Rust/Swift FFI ABI and associated identifiers to SciLaxy-owned names, updates capturer documentation to accurately describe HEVC output, and migrates smoke tooling from XYZEN environment variables and service labels to SCILAXY equivalents. Sequence diagram for HEVC capture through the renamed FFIsequenceDiagram
participant Rust as Rust capturer
participant Swift as Swift MacCapturer
participant WS as Stream publisher
Rust->>Swift: scilaxy_capturer_start(width, height, fps, bitrateKbps, displayId, ctx, cb)
Swift-->>Rust: HEVC NAL callback
Rust->>WS: Send HEVC NAL binary frame
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
嘿——我发现了 1 个问题
面向 AI 代理的提示
请处理本次代码审查中的评论：
## 单独评论
### 评论 1
<location path="scripts/dump_view.py" line_range="11" />
<code_context>
+PORT = int(os.environ.get("SCILAXY_STREAM_PORT", "21130"))
peer = sys.argv[1] if len(sys.argv) > 1 else "test123"
secs = float(sys.argv[2]) if len(sys.argv) > 2 else 3.0
out_path = sys.argv[3] if len(sys.argv) > 3 else "/tmp/sample.h264"
</code_context>
<issue_to_address>
**小问题：** 当省略输出路径时，`dump_view.py` 会将 HEVC NAL 流写入 `/tmp/sample.h264`，因此生成的文件会被标记为 H.264，尽管 macOS 捕获器现在输出的是 HEVC。
**触发条件：** 在不提供可选输出路径参数的情况下运行 `dump_view.py`。
**建议修复：** 将默认路径改为 HEVC 扩展名，例如 `/tmp/sample.h265` 或 `/tmp/sample.hevc`。
```suggestion
out_path = sys.argv[3] if len(sys.argv) > 3 else "/tmp/sample.h265"
```
</issue_to_address>Original comment in English
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="scripts/dump_view.py" line_range="11" />
<code_context>
+PORT = int(os.environ.get("SCILAXY_STREAM_PORT", "21130"))
peer = sys.argv[1] if len(sys.argv) > 1 else "test123"
secs = float(sys.argv[2]) if len(sys.argv) > 2 else 3.0
out_path = sys.argv[3] if len(sys.argv) > 3 else "/tmp/sample.h264"
</code_context>
<issue_to_address>
**nitpick:** When the output path is omitted, `dump_view.py` writes the HEVC NAL stream to `/tmp/sample.h264`, so the generated file is labeled as H.264 even though the macOS capturer now emits HEVC.
**Triggers:** When `dump_view.py` is run without its optional output-path argument.
**Suggested fix:** Change the default path to an HEVC extension such as `/tmp/sample.h265` or `/tmp/sample.hevc`.
```suggestion
out_path = sys.argv[3] if len(sys.argv) > 3 else "/tmp/sample.h265"
```
</issue_to_address>| PORT = int(os.environ.get("SCILAXY_STREAM_PORT", "21130")) | ||
| peer = sys.argv[1] if len(sys.argv) > 1 else "test123" | ||
| secs = float(sys.argv[2]) if len(sys.argv) > 2 else 3.0 | ||
| out_path = sys.argv[3] if len(sys.argv) > 3 else "/tmp/sample.h264" |
There was a problem hiding this comment.
小问题： 当省略输出路径时，dump_view.py 会将 HEVC NAL 流写入 /tmp/sample.h264，因此生成的文件会被标记为 H.264，尽管 macOS 捕获器现在输出的是 HEVC。
触发条件： 在不提供可选输出路径参数的情况下运行 dump_view.py。
建议修复： 将默认路径改为 HEVC 扩展名，例如 /tmp/sample.h265 或 /tmp/sample.hevc。
Suggested change
| out_path = sys.argv[3] if len(sys.argv) > 3 else "/tmp/sample.h264" | |
| out_path = sys.argv[3] if len(sys.argv) > 3 else "/tmp/sample.h265" |
Original comment in English
nitpick: When the output path is omitted, dump_view.py writes the HEVC NAL stream to /tmp/sample.h264, so the generated file is labeled as H.264 even though the macOS capturer now emits HEVC.
Triggers: When dump_view.py is run without its optional output-path argument.
Suggested fix: Change the default path to an HEVC extension such as /tmp/sample.h265 or /tmp/sample.hevc.
Suggested change
| out_path = sys.argv[3] if len(sys.argv) > 3 else "/tmp/sample.h264" | |
| out_path = sys.argv[3] if len(sys.argv) > 3 else "/tmp/sample.h265" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Sourcery 摘要
移除已弃用的中继来源信息，并使采集器接口、HEVC 文档和冒烟测试工具与 SciLaxy 命名方案保持一致。
改进：
文档：
杂项：
Original summary in English
Summary by Sourcery
Remove retired relay provenance and align capturer interfaces, HEVC documentation, and smoke tooling with the SciLaxy naming scheme.
Enhancements:
Documentation:
Chores: