feat(cuda): add CUDA 13.0.0 jobs to the compile workflow - #1439
Conversation
|
Thanks for putting this together so quickly! Would you mind spitting the PR into 3 parts:
Sorry for the extra work. |
|
Ok @martindevans, working on it |
Extend the cublas matrix and Gather Binaries layout so a Compile run can produce cu13.0.0 artifacts next to cu12.4.0 without changing the managed loader or NuGet packages yet.
011ecf3 to
4ee1652
Compare
|
@martindevans Split as you asked. Same code as before, three PRs:
Please merge in that order. I will rebase 1440 onto master after this one lands, then 1441 after 1440. |
|
Alright this all looks good to me! Thanks for splitting it up, it's much easier to handle this way. Could you start a test run over in your repo (I would do it myself, but unfortunately I can't do it here until it's merged, and I don't have permission to do it in your fork). To do that:
|
e6b420b to
fb9ddaf
Compare
|
It looks like your test run worked (https://github.com/modelpath-dev/LLamaSharp/actions/runs/36240372366), so I'll merge this and start a run in this repo. Once it's done I'll upload the binaries and we can start using those in dev. |
Why
Martin asked to split the CUDA 13 work so the compile workflow can land first. Maintainers can then run a Compile build and refresh the development binaries package before the managed loader or NuGet packages change.
This is part 1 of 3 for #1360.
Scope
.github/workflows/compile.yml: add13.0.0to the cublas matrix, useJimver/cuda-toolkit@v0.2.36for non-12.4.0 installs, and gathercu13.0.0Windows/Linux artifacts next tocu12.4.0.Out of scope here:
NativeLibraryWithCuda,LLamaSharp.Backend.Cuda13nuspecs,LLamaSharp.Runtime.targets, and docs.Tradeoffs
Kept the existing
12.4.0toolkit pin on@v0.2.15and only moved newer matrix values to@v0.2.36, so the CUDA 12 path stays unchanged while 13 can install.Blast Radius
Only the Compile workflow and its published native artifact layout change. No managed package or runtime load path changes until parts 2 and 3.
Verification
757b5dd6…)..github/workflows/compile.yml(+33/−4).dotnetis not installed on this machine, so Compile CI on GitHub is the live check for the new matrix jobs.Stack: