Expose trusted native input events - #472
Merged
Merged
Conversation
This was referenced Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unchanged VS Code drops native nested-webview link clicks and keyboard forwarding because WebScene's host-dispatched Event objects have no
isTrustedvalue. This change exposesisTrusted: truefor events emitted inside the native input dispatch scope while preservingfalsefor constructed events andHTMLElement.click()activation, including calls made from trusted handlers.The change adds event provenance only. Existing VS Code listeners retain link, context-menu, and keyboard handoff ownership, and existing native host requests retain navigation authority.
Validation was intentionally not run under the current implementation-only directive. Chromium/WPT comparison, native input/link coverage, synthetic-click isolation, performance/lifecycle checks, packaging, and cumulative unchanged-consumer acceptance remain recorded validation debt on #470 and #268.
Closes #470