Skip to content

Split inputs and results only in a space wider than tall - #89

Merged
RISCfuture merged 1 commit into
mainfrom
ipad-horizontal-split
Nov 18, 2026
Merged

RISCfuture merged 1 commit into
mainfrom
ipad-horizontal-split

Conversation

@RISCfuture

Copy link
Copy Markdown
Contributor

Summary

Since #83, Takeoff and Landing split into two forms at any regular width. On an iPad in portrait, ArrangementView stacked those forms vertically: inputs in the top 62%, results below, and each scrolled on its own.

PerformanceLayout now uses the split only where the size class is regular and the space is wider than tall, which it learns from onGeometryChange. Everywhere else it shows the single compact-width form. The split goes back to the stock .split style, and the custom vertical ratio is removed.

Device Layout
iPhone One form (unchanged)
iPhone Duo, folded One form
iPhone Duo, unfolded Side by side along the fold (runs in landscape, 951 × 669 pt)
iPad portrait (mini, 13" Pro) One form, results below inputs
iPad landscape (mini, 13" Pro) Side by side

A first attempt with .split.axes(.horizontal) hid the results pane completely in portrait, because the arrangement shows only the primary view when it can't split along the allowed axis. That's why this checks the shape instead.

Testing

  • Checked by eye on simulators (iOS 27.2) on all the devices in the table, at OAK 28R.
  • swift-format and SwiftLint pass; the app builds.
  • I haven't run the unit or UI tests locally. CI runs the UI tests on iPhone, iPad and Duo. performanceInputs and performanceResults already fall back to the single form when the panes don't exist.

No CHANGELOG entry: 4.0.1 has shipped, and there's no unreleased section yet.

🤖 Generated with Claude Code

At regular width the performance screens always split into two forms, so
an iPad in portrait stacked them, each scrolling on its own, with the
inputs in the top 62% and the results below. The split now applies only
where the space is wider than tall: iPad in landscape and iPhone Duo's
inner display, which runs in landscape across the fold. Everywhere else
the screens show one form, inputs first, as at compact width.

The shape is taken only when the width changes. The software keyboard
shortens the space without narrowing it, and on an iPad in portrait it
leaves the space wider than tall; measuring then would switch to the
split and rebuild the forms under the field being edited, dismissing the
keyboard.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@RISCfuture
RISCfuture force-pushed the ipad-horizontal-split branch from 1af0d62 to ef0a27e Compare November 18, 2026 16:42
@RISCfuture
RISCfuture merged commit 4580f56 into main Nov 18, 2026
9 checks passed
@RISCfuture
RISCfuture deleted the ipad-horizontal-split branch November 18, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant