Repository navigation
Split inputs and results only in a space wider than tall - #89
Merged
Merged
Conversation
At regular width the performance screens always split into two forms, so an iPad in portrait stacked them, each scrolling on its own, with the inputs in the top 62% and the results below. The split now applies only where the space is wider than tall: iPad in landscape and iPhone Duo's inner display, which runs in landscape across the fold. Everywhere else the screens show one form, inputs first, as at compact width. The shape is taken only when the width changes. The software keyboard shortens the space without narrowing it, and on an iPad in portrait it leaves the space wider than tall; measuring then would switch to the split and rebuild the forms under the field being edited, dismissing the keyboard. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
RISCfuture
force-pushed
the
ipad-horizontal-split
branch
from
November 18, 2026 16:42
1af0d62 to
ef0a27e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since #83, Takeoff and Landing split into two forms at any regular width. On an iPad in portrait,
ArrangementViewstacked those forms vertically: inputs in the top 62%, results below, and each scrolled on its own.PerformanceLayoutnow uses the split only where the size class is regular and the space is wider than tall, which it learns fromonGeometryChange. Everywhere else it shows the single compact-width form. The split goes back to the stock.splitstyle, and the custom vertical ratio is removed.A first attempt with
.split.axes(.horizontal)hid the results pane completely in portrait, because the arrangement shows only the primary view when it can't split along the allowed axis. That's why this checks the shape instead.Testing
performanceInputsandperformanceResultsalready fall back to the single form when the panes don't exist.No CHANGELOG entry: 4.0.1 has shipped, and there's no unreleased section yet.
🤖 Generated with Claude Code