Skip to content

Feature/acastill lightpropagation update - #946

Open
asanchezcastillo wants to merge 9 commits into
developfrom
feature/acastill_lightpropagation_update
Open

Feature/acastill lightpropagation update#946
asanchezcastillo wants to merge 9 commits into
developfrom
feature/acastill_lightpropagation_update

Conversation

@asanchezcastillo

@asanchezcastillo asanchezcastillo commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Description

This PR does:

  • Modify the standard MC workflow to add lightpropagationcorrection module to the default chain.
  • Clean up and factorization of the lightpropagationcorrection module.
  • Include the particle propagation time calculation. This is saved as an attribute of the CorrectedOpFlashTiming object. This is required for downstream correction (more information here)

$${\color{blue}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

$${\color{blue}\bf{\textrm{IMPORTANT UPDATE Feb 2nd 2026:}}}$$ If you are making a PR which is intended as a patch for the CURRENT production for gen 2 SBND analyses, you must make two PRs: one for develop and one for the production/sbnd-gen2 branch.

$${\color{blue}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • Does this affect the standard workflow?
  • Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch!

Relevant PR links (optional)

Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?
This PRs should be merged with
SBNSoftware/sbnobj#175
SBNSoftware/sbncode#666
SBNSoftware/sbnanaobj#195

Link(s) to docdb describing changes (optional)

Is there a docdb describing the issue this solves or the feature added?

@tjones79 tjones79 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great thanks @asanchezcastillo

Few minor changes before approval :)

Comment thread sbndcode/LightPropagationCorrection/LightPropagationCorrection_module.cc Outdated
Comment thread sbndcode/LightPropagationCorrection/LightPropagationCorrection_module.cc Outdated
Comment thread sbndcode/LightPropagationCorrection/LightPropagationCorrection_module.cc Outdated
Comment thread sbndcode/LightPropagationCorrection/LightPropagationCorrection_module.cc Outdated
Comment thread sbndcode/LightPropagationCorrection/LightPropagationCorrection_module.hh Outdated
@asanchezcastillo

Copy link
Copy Markdown
Contributor Author

Hi @tjones79 ! Thanks for the thorough review. I have implemented the requested changes and the PR should be good to go!

@aantonakis

Copy link
Copy Markdown
Contributor

Hi @JosiePaton , this PR requires your review since it affects the CAF data format. Just checking if you're available to review this PR soon or if we should reach out to a different CAF expert? thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants