Feature/acastill lightpropagation update - #946
Open
asanchezcastillo wants to merge 9 commits into
Open
Conversation
This was referenced Jul 21, 2026
asanchezcastillo
marked this pull request as ready for review
July 29, 2026 14:25
7 tasks
tjones79
self-requested a review
August 11, 2026 16:57
tjones79
requested changes
Aug 11, 2026
tjones79
left a comment
There was a problem hiding this comment.
This looks great thanks @asanchezcastillo
Few minor changes before approval :)
Contributor
Author
|
Hi @tjones79 ! Thanks for the thorough review. I have implemented the requested changes and the PR should be good to go! |
Contributor
|
Hi @JosiePaton , this PR requires your review since it affects the CAF data format. Just checking if you're available to review this PR soon or if we should reach out to a different CAF expert? thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR does:
Checklist
Reviewers,AssigneesDevelopementRelevant PR links (optional)
Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?
This PRs should be merged with
SBNSoftware/sbnobj#175
SBNSoftware/sbncode#666
SBNSoftware/sbnanaobj#195
Link(s) to docdb describing changes (optional)
Is there a docdb describing the issue this solves or the feature added?