Repository navigation
Commit the strong-name key - #14
Merged
Merged
Conversation
Key.snk is now tracked, as Microsoft recommends for open-source projects (a strong name provides identity, not security): local and CI builds share the same assembly identity. The build no longer generates a key when it is missing, and the release workflow no longer needs a secret for it.
There was a problem hiding this comment.
🟢 Approval recommended
The committed key is structurally valid and all build, CI, ignore, and documentation changes are consistent.
0 open findings
What changed in this PR
Commits the strong-name key so local and CI builds produce assemblies with consistent identity.
Changes:
- Adds and documents the repository-owned
Key.snk. - Removes local key generation and CI secret restoration.
- Updates release notes and ignore rules.
| File | Description |
|---|---|
Key.snk |
Adds the strong-name key. |
.gitignore |
Allows the key to be tracked. |
SourceControlSwitcher/SourceControlSwitcher.csproj |
Removes fallback key generation. |
.github/workflows/release.yml |
Uses the committed key during releases. |
BUILD.txt |
Documents the key’s purpose. |
CHANGELOG.txt |
Records the assembly identity change. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The strong-name key (
Key.snk) is now part of the repository, as Microsoft recommends for open-source projects: every build, local or CI, produces the same assembly identity.