Repository navigation
Conversation
kra
added this pull request to stack #1489
October 9, 2026 17:31
✅ Deploy Preview for antenna-ssec canceled.
|
✅ Deploy Preview for antenna-preview canceled.
|
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 56 minutes. View limit details
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check |  |
The description gives the reason for the removal but omits most required sections, including the summary, detailed description, testing information, deployment notes, and checklist. | Complete the required pull request template. Add the summary, list of changes, related issues or state that none apply, detailed description with risks, testing steps and results, screenshots or an applicable statement, deployment notes, an… |
✅ Passed checks (4 passed)
-
Check name Status Explanation Docstring Coverage No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Title check The title clearly identifies the removal of TaxonManager.with_children(), which matches the main change.
Full details: Description check
-
Resolution
Complete the required pull request template. Add the summary, list of changes, related issues or state that none apply, detailed description with risks, testing steps and results, screenshots or an applicable statement, deployment notes, and checklist status.
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
mihow
reviewed
Oct 9, 2026
|
|
||
| logging.info(f"Updated parents for {len(bulk_update_data)} taxa") | ||
|
|
||
| def with_children(self): |
Collaborator
There was a problem hiding this comment.
Funny I think this was a note to myself, because we do need to query all children for some missing features, and I will not remember how to do this:
taxa = Taxon.objects.filter(parents_json__contains=[{"id": taxon.id}])
qs = qs.annotate(children=models.Subquery(taxa.values("id")))
Maybe that can go in a docstring somewhere else.
Collaborator
Author
There was a problem hiding this comment.
add it to the issue that adds the missing features?
- _case_from_map - verified_taxon_counts - TaxonRank - TaxonQuerySet - TaxonManager - TaxonParent - Taxon - TaxaListQuerySet - TaxaListManager - TaxaList - Tag Because main.models still has to re-export from models_future until migrations and other code stops referencing it: - Added imports in some methods, since module-level imports must be avoided to avoid circular imports. - Changed type hinting for some methods to strings (to be evauluated by the linter without a change in behavior) to avoid circular imports. Added unit tests for models_future.taxonomy. Some of these were driven by coverage needs. I didn't remove tests from ami.main, which means we have duplicate coverage. The tests were all blatted out by AI and I didn't work hard to understand them. There should be no functionality changes, including possible bugfixes.
… the implentation is example code with a hardoded key which will be an error if used.
kra
force-pushed
the
kra/model-split-tests-storage-taxonomy-withchildren
branch
from
October 9, 2026 22:48
17bce99 to
4c75062
Compare
- _case_from_map - verified_taxon_counts - TaxonRank - TaxonQuerySet - TaxonManager - TaxonParent - Taxon - TaxaListQuerySet - TaxaListManager - TaxaList - Tag Because main.models still has to re-export from models_future until migrations and other code stops referencing it: - Added imports in some methods, since module-level imports must be avoided to avoid circular imports. - Changed type hinting for some methods to strings (to be evauluated by the linter without a change in behavior) to avoid circular imports. Added unit tests for models_future.taxonomy. Some of these were driven by coverage needs. I didn't remove tests from ami.main, which means we have duplicate coverage. The tests were all blatted out by AI and I didn't work hard to understand them. There should be no functionality changes, including possible bugfixes.
…olnickLab/antenna into kra/model-split-tests-storage-taxonomy
… the implentation is example code with a hardoded key which will be an error if used.
… github.com:RolnickLab/antenna into kra/model-split-tests-storage-taxonomy-withchildren
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… the implentation is example code with a hardcoded key which will be an error if used.
Summary by CodeRabbit
with_children()method for taxon queries.