Add Humble to the Windows build-and-test matrix - #1584
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The change is a straightforward CI-matrix extension consistent with the existing workflow pattern and includes the required per-distro configuration (URL and run_tests flag).
Pull request overview
This PR extends the Windows reusable CI workflow’s ROS 2 matrix to include Humble, aligning with the repository’s documented Windows support and ensuring the Humble + Windows combination gets CI coverage (build-only, no tests).
Changes:
- Add
humbleto theros_distributionmatrix for the Windows build workflow. - Add a Humble-specific
includeentry with a pinned ROS 2 Windows binary zip URL andrun_tests: falseto match the existing non-lyrical distributions’ behavior.
File summaries
| File | Description |
|---|---|
| .github/workflows/windows-build-and-test.yml | Adds Humble to the Windows build matrix and defines its pinned ROS 2 binary download + build-only behavior. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
coverage: 91.067% (-0.02%) from 91.087% — minggangw:fix-1583 into RobotWebTools:develop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
windows-build-and-test.ymlonly tested jazzy/kilted/lyrical/rolling, despitedocs/BUILDING.mddocumenting Humble as a supported ROS 2 distribution on Windows — zero CI coverage existed for that combination.humbleto the matrix, build-only (run_tests: false), matching the existing jazzy/kilted pattern — onlylyricalruns the full test suite on Windows.Fix: #1583