Repository navigation
Reject Tribute attachment to non-editable elements - #21
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
pkaminski
left a comment
There was a problem hiding this comment.
@pkaminski reviewed 9 files and all commit messages.
Reviewable status: 0 of 9 files reviewed, all discussions resolved (waiting on earlAchromatic).
bf6b17a to
5bb91ac
Compare
earlAchromatic
left a comment
There was a problem hiding this comment.
Reproduced attachment to plain and explicitly non-editable divs on the base and verified that both are rejected after the fix.
Don't forget to update client's Tribute dependency after this lands.
@earlAchromatic+SAGE reviewed 9 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on earlAchromatic).
f081cb4 to
a6c8332
Compare
a6c8332 to
f081cb4
Compare
Attaching Tribute to a plain div or to
contenteditable="false"currently succeeds becausecontentEditablecontains a truthy string. CheckisContentEditableinstead so the existing error guard uses effective editability, including inheritance. Inputs and textareas remain accepted.Add six browser regression cases covering plain and explicitly disabled divs, explicit and inherited editability, inputs, and textareas. Update the README examples, rebuild all distributed bundles, and bump the publishable library from 5.1.3 to 5.1.4.
Validation: the two rejection tests failed against the original bundles while the other 36 passed. After the fix and Rollup rebuild, all 38 tests pass in headless Chrome.
git diff --checkpasses.Follow-up to the migration review. Stacked above security PR #18 and Yarn migration #19; merge from the bottom of the stack.
Linux CI also passes: immutable install, build, and all 38 browser tests. This PR is now part of native stack #20; Jacob (
@earlAchromatic) is requested for review.This change is