Skip to content

fix: unblock repository settings and clear stale project paths - #867

Merged
RetroGameDeveloper merged 1 commit into
mainfrom
fix/repository-settings-loading
Nov 8, 2026
Merged

RetroGameDeveloper merged 1 commit into
mainfrom
fix/repository-settings-loading

Conversation

@RetroGameDeveloper

Copy link
Copy Markdown

Fix

A project switch disabled automatic-commit controls while repository setup loaded, but retained the previous project's Git path/status. Slow status reads therefore looked like a permanently disabled checkbox tied to the wrong game.

  • Clear previous project repository paths/status immediately; display current-project loading state and an indeterminate progress bar.
  • Bound the browser status request to 15 seconds and offer an explicit retry on failure. Do not duplicate an outstanding request; abort old project fetches and reject stale scoped results.
  • Identify server status responses by project slug.
  • Metadata-only checkout validation (clean=False) now skips git status --untracked-files=all. That full worktree scan is unnecessary for repository identity and particularly expensive in build checkouts. Cleanliness checks before writes retain the existing scan/safety behavior.
  • Route read-only setup status through the reserved snapshot lane instead of queueing behind general long-running operations.

Verification

133 Python tests passed (repository setup/sync, the new metadata-only regression and repository route tests). Four Node GUI suites passed: repository setup, push, sync and save-folder behavior; setup tests cover project-switch stale paths, disabled controls, timeout/retry, late responses and automatic enable preparation. Ruff and git diff --check pass.

No live save locations, Git repositories, preferences or working projects were changed. Auto-commit remains an explicit user opt-in. Shared behavior applies to ROM progress repositories and imported source checkout metadata.

@github-actions github-actions Bot added the bug Something isn't working label Nov 8, 2026
@RetroGameDeveloper
RetroGameDeveloper merged commit 428bbe5 into main Nov 8, 2026
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant