Repository navigation
fix: keep fork projects separate from upstream by default - #865
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying the RetroReversing fork previously selected upstream's
~/Decompdatabase by default, despite the fork's different database format. Installed copies now select~/Decomp-RetroReversing; checkouts and separate Run from Git handoffs select~/Decomp-RetroReversing-dev. Explicit DECOMP_HOME overrides and the deliberate current-data handoff remain supported. No old folder is opened, copied or migrated automatically.Use one default-home helper for normal startup and source handoffs. Update source-launch UI wording, installer comments, README/contributor documentation and the site. Remove the README's old advice to reuse an upstream database, and point the fork site's install commands at this fork's installer.
Validation: 82 edition/source-runtime/source-checkout/updater/Windows-host tests passed, 6 platform-specific tests skipped; full source/test/project lint passed. Regression coverage leaves upstream database and server-state sentinels untouched, checks installed/development defaults and explicit overrides, and verifies both source handoff choices. A fresh macOS app will be built before delivery. The running app and its data are untouched.
The native Apple Silicon app builds successfully. Its bundled interpreter was checked with an isolated HOME: installed startup selects Decomp-RetroReversing, source handoffs select Decomp-RetroReversing-dev, and an explicit DECOMP_HOME remains unchanged. Repository instructions now document the new defaults. GitHub reports no required checks; the broader optional cross-platform suites are still running. The user requested merge and a Mac rebuild only, without a new release.