Repository navigation
N64 textures found from the display lists that load them (decomp-assets 0.3.0) - #1180
Merged
Merged
Conversation
…r shows 453, a futuristic racer 394 decomp-assets 0.3.0 reads uncompressed display lists' texture loads (format, size, palette) and works out where each file sits in the cartridge from its vertex loads and the pointers to its lists. Cartridges with no container format had empty texture browsers. ROADMAP lists what it doesn't read yet. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps decompassets to v0.3.0: a new N64 recogniser finds textures from the uncompressed display lists that load them (format, dimensions, palette from the RDP commands), placing each file in the cartridge by its vertex loads and the pointers to its lists. They show in the texture browser as
CI8 32×64 textureetc., with confidenceinferred. ROADMAP: the texture row mentions it; "Next" lists what it doesn't read yet.Why
Cartridges with no container format the recognisers know had empty texture browsers.
Checked
Through the app's code (
consoles.get('n64').asset_regions→rom.explorer.analyse→asset_preview), on the user's cartridges in a scratch home, read only:48 random textures from each were rendered and all are real images with correct palettes.
Targeted tests (test_decompassets, test_archived_textures, test_asset_inspection, test_native_textures, test_rom_assets, test_rom_explorer, test_texture_browser, test_asset_map): 147 passed, 1 failed. The failure is
test_texture_browser.py::test_api_selections_persist_and_usage_keeps_recorded_references_separate, which fails on main too.Other consoles: unaffected (N64 recogniser). Existing projects need a ROM Explorer rescan.
🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.