Repository navigation
N64 texture banks with a name block are found and named (decomp-assets 0.2.0) - #1176
Merged
Merged
Conversation
…a Turok-engine shooter's browser shows 990 textures
decomp-assets 0.2.0 accepts the indexed texture bank's fourth block, the texture's
source file name ("BUSH01.GIF"), which a later version of the engine appends. The
recogniser required exactly three blocks, so a 16 MB Turok-engine shooter's texture
browser was empty although all its RNC blocks decode. Rescanned, it finds 990 banks,
labelled by their file names; the original Turok-format game is unchanged (1,070).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps decompassets to v0.2.0: indexed N64 texture banks may carry a fourth block, the texture's source file name, which becomes the bank's label in the texture browser. ROADMAP's texture-bank row mentions it.
Why
A 16 MB Turok-engine shooter had an empty texture browser: all 5,856 RNC blocks decode, but each texture bank has a fourth name block and the recogniser required exactly three.
Checked
consoles.get('n64').asset_regions→rom.explorer.analyse→asset_decode/asset_preview) on the user's cartridge in a scratch home, read only: 990 banks (930 CI4, 33 RGBA16 mipmap, 27 CI8), labelledBUSH01.GIF,DAISY.GIF w/mask, ...; previews render. The Turok-format game still gives 1,070.pyteston test_decompassets, test_archived_textures, test_asset_inspection, test_native_textures, test_rom_assets, test_rom_explorer, test_texture_browser: 140 passed, 1 failed.test_texture_browser.py::test_api_selections_persist_and_usage_keeps_recorded_references_separatefails on main as well (checked in a clean main worktree), so it isn't caused by this change.Existing projects need a ROM Explorer rescan to pick these up.
🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.