Skip to content

Update claims-system.md - #427

Merged
Nepiki merged 1 commit into
RetroAchievements:mainfrom
kiwitaco:patch-14
Sep 24, 2026
Merged

Nepiki merged 1 commit into
RetroAchievements:mainfrom
kiwitaco:patch-14

Conversation

@kiwitaco

Copy link
Copy Markdown
Contributor

Update the collaboration claim rule to mark as free. Clean up the own revision claim point

Update the collaboration claim rule to mark as free.
Clean up the own revision claim point
@greptile-apps

greptile-apps Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

Not safe to merge until subset eligibility rules agree.

Summary

Clarifies free collaboration and revision claims.

  • Adds collaboration completion requirements.
  • Expands own-revision eligibility, conflicting with subset policy.

Reviews (1) · Last reviewed commit: "Update claims-system.md"

- If a developer makes a revision or subset claim, the claim can be set to "Own Revision" depending on criteria I haven't copy-pasted into this section yet.
- Collaboration claims.
- Collaboration claims after the developer's part has been completed. To request a free claim on a completed collaboration claim, the lead of the collaboration sends a message to DevCompliance when they agree that the work of one of the collaborators is ready for release. This includes having serviceable badges.
- Own revision claims upon request, including subset claims where the developer is the author or claimant of the base set.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Conflicting subset claim eligibility

This grants free subset claims to non-author base-set claimants, while subset_design.md says developers without core-set authorship are ineligible. The conflicting rules can cause claims to be marked free incorrectly.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was already how things worked out for concurrent claims. The subset page just does not mention that practice, it's not in explicit contradiction.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That’s fair. If the subset guidance does not explicitly prohibit this and the free-claim treatment reflects the established practice for concurrent claims, then this is not a documentation conflict. I’m withdrawing the finding.

Tip: You can customize Greptile's behavior for this repo with .greptile/rules.md and .greptile/config.json.

@Nepiki
Nepiki merged commit 66cc7ae into RetroAchievements:main Sep 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants