Skip to content

RC-T42 Account and Security Tab fix, Usability fixes, Translation Fixes - #74

Merged
ucswift merged 2 commits into
masterfrom
develop
Oct 9, 2026
Merged

ucswift merged 2 commits into
masterfrom
develop

Conversation

@ucswift

@ucswift ucswift commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Visual Updates

    • Improved color contrast and consistency across light and dark themes, including chat, calls, command boards, forms, badges, and navigation.
    • Updated priority and status badges to use more readable text colors.
  • Bug Fixes

    • Check-in statuses now recognize current and legacy labels, and overdue counts include critical statuses.
    • Duplicate personnel entries no longer inflate check-in or accountability totals.
    • Improved handling of operation and deployment errors, and corrected navigation to account security settings.
  • Localization

    • Expanded translations across multiple languages, including check-in statuses, sign-in verification, incident assistant, and call history.

@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 5bebdf02-3b49-4220-8b8c-c07313fa92b0

📥 Commits

Reviewing files that changed from the base of the PR and between f55bd58 and 626bee3.


📒 Files selected for processing (10)
  • src/app/(app)/command.tsx
  • src/components/calls/__tests__/location-history-panel.test.tsx
  • src/components/calls/call-card.tsx
  • src/components/calls/location-history-panel.tsx
  • src/components/command/__tests__/resource-cards.test.tsx
  • src/components/command/resource-cards.tsx
  • src/components/command/resource-details-sheet.tsx
  • src/lib/__tests__/readable-text-color.test.ts
  • src/lib/utils.ts
  • src/stores/operations/__tests__/store.test.ts

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour.



📝 Walkthrough

Walkthrough

The pull request updates theme and component styling, adds readable-color and duplicate-record handling, expands check-in status handling, changes error mapping, and updates translations in ten languages.

Changes

Theme and interface

Layer / File(s) Summary
Theme and shared UI foundations
theme-tokens.css, src/app/_layout.tsx, src/lib/utils.ts, src/components/ui/*
Dark-mode primary tokens change. Shared UI components and utilities update color, icon, progress, and tab-label handling.
App screens and navigation
src/app/*
App screens update theme-dependent colors and loading indicators. The account-security route target and screen header settings change.
Component presentation and theme colors
src/components/calls/*, src/components/chat/*, src/components/command/*, src/components/contacts/*, src/components/data-protection/*, src/components/notifications/*, src/components/settings/*, src/components/shared-session/*, src/components/*
Components update text, background, badge, icon, and spinner styling. Priority and status badges use derived readable colors where described.
Shared controls and component behavior
src/components/common/*
The back button uses explicit styles for its pressable. The icon loading state spins a wrapping view. Tests cover the back-button sizing and press behavior.

Accountability deduplication

Layer / File(s) Summary
Deduplicate accountability records
src/lib/incident-command-utils.ts, src/components/command/command-board.tsx, src/services/incident-assistant/answerers.ts, src/stores/check-in-timers/store.ts, related tests
A helper retains the first row for each user ID. The command board, assistant PAR calculations, and personnel-status store use deduplicated rows. Tests cover duplicate records.

Check-in status handling

Layer / File(s) Summary
Timer status mapping and overdue handling
src/components/check-in-timers/*, src/app/call/[id].tsx
Timer cards map legacy and server statuses to labels and colors. Unknown statuses display their raw values. Critical and legacy Overdue are classified as overdue.

Error response handling

Layer / File(s) Summary
Normalize operation and deployment errors
src/lib/operations/time.ts, src/stores/records/deployments-store.ts, related tests
HTTP 400 operation errors return an allowlisted reason or validation. Deployment-store errors outside 403 and 404 use the fallback message.

Translations

Layer / File(s) Summary
Localized interface strings
src/translations/*.json
Arabic, German, Greek, English, Spanish, French, Italian, Polish, Swedish, and Ukrainian files add or update interface translations.

Priority: ⬇️ Low

Estimated code review effort: 4 (Complex) | ~60 minutes

Change: Bug fix


Merge Risk: ⚪ Minimal · up to 626be

The reviewed changes update badge and text colors, and their tests cover readable-color selection. No merge-blocking risk was found in the reviewed portion.

Pre-merge checks | Passed 4 | Failed 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 24 functions across 54 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title identifies the account and security fix, usability changes, and translation updates. These topics are present in the pull request, although the wording is broad.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.


  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR

🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR


  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@ucswift
ucswift merged commit f0d8cfc into master Oct 9, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant