Skip to content

RC-T42 Fixes for Apple Review - #73

Merged
ucswift merged 1 commit into
masterfrom
develop
Oct 9, 2026
Merged

ucswift merged 1 commit into
masterfrom
develop

Conversation

@ucswift

@ucswift ucswift commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Updates
    • Location access is now limited to foreground use for incident maps, calls, check-ins, photos, and chat. Location is not tracked in the background, and motion data for incident-map accuracy stays on-device.
    • In China, native call integration is unavailable: call setup is skipped, and calls are not started or reported through CallKeep.

@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: d0a3de87-7550-4ea0-8338-c1acb559255c

📥 Commits

Reviewing files that changed from the base of the PR and between 8561655 and b7643e1.


📒 Files selected for processing (3)
  • app.config.ts
  • src/services/__tests__/callkeep.service.ios.test.ts
  • src/services/callkeep.service.ios.ts

Included review availability: This review used your included allowance. 1 included review remains after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour. Your free on-demand review promotion remains active until October 9, 2026 at 6:00 PM UTC.



📝 Walkthrough

Walkthrough

The app configuration now describes foreground-only location use and removes background location settings. The iOS CallKeep service checks the device region and skips setup and call startup in CN and CHN. Tests cover restricted and unrestricted regions.

Changes

Foreground location configuration

Layer / File(s) Summary
Foreground-only location settings
app.config.ts
Location and motion purpose strings now describe foreground use. Background location and foreground service settings, plus the periodic location task, are removed.

Regional CallKit restrictions

Layer / File(s) Summary
Region checks for CallKeep setup and calls
src/services/callkeep.service.ios.ts, src/services/__tests__/callkeep.service.ios.test.ts
The service checks the first locale’s region before setup and call startup. It skips both operations for CN and CHN. Tests cover the region helper, setup behavior, and call startup, including a region change after setup.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix

Sequence Diagram(s)

sequenceDiagram
  participant App
  participant CallKeepService
  participant ExpoLocalization
  participant CallKeep
  App->>CallKeepService: setup
  CallKeepService->>ExpoLocalization: getLocales
  ExpoLocalization-->>CallKeepService: first locale region
  alt Region is CN or CHN
    CallKeepService-->>App: return without CallKeep setup
  else Region is not restricted
    CallKeepService->>CallKeep: setup and register event listeners
  end
  App->>CallKeepService: startCall
  CallKeepService->>ExpoLocalization: getLocales
  ExpoLocalization-->>CallKeepService: first locale region
  alt Region is CN or CHN
    CallKeepService-->>App: return empty string
  else Region is not restricted
    CallKeepService->>CallKeep: start call
  end
Loading

Merge Risk: ⚪ Minimal · up to b7643

No demonstrated issue blocks merging. The complete location startup path was not verified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title identifies the pull request as fixes for Apple Review. This matches the changes that restrict background location use and disable CallKit in restricted regions.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.


✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR

🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR


  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@ucswift
ucswift merged commit d74953e into master Oct 9, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant