Skip to content

Revert "MOD-19919: Retry RDB reload saves that collide with BGSAVE" - #261

Merged
gabsow merged 1 commit into
masterfrom
revert-260-codex/mod-19919-save-retry
Oct 22, 2026
Merged

gabsow merged 1 commit into
masterfrom
revert-260-codex/mod-19919-save-retry

Conversation

@gabsow

@gabsow gabsow commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Reverts #260


Note

Medium Risk
Tests that use dumpAndReload during concurrent BGSAVE may flake or fail where the reverted retry logic previously absorbed the race.

Overview
Reverts the MOD-19919 behavior that retried SAVE during StandardEnv.dumpAndReload when Redis returned Background save already in progress.

dumpAndReload (non-restart path) again calls save() once per master/replica connection with no retry loop, timeout, or sleep. The _SAVE_RETRY_TIMEOUT constant is removed.

The unit tests that covered busy-save retries, timeout-without-reload, and non-retryable save errors are deleted along with related unittest.mock / redis imports.

Reviewed by Cursor Bugbot for commit 9b401f1. Bugbot is set up for automated code reviews on this repo. Configure here.

@gabsow
gabsow requested a review from AvivDavid23 October 22, 2026 07:33
@gabsow
gabsow merged commit 69ed556 into master Oct 22, 2026
11 checks passed
@gabsow
gabsow deleted the revert-260-codex/mod-19919-save-retry branch October 22, 2026 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant