Repository navigation
Revert "MOD-19919: Retry RDB reload saves that collide with BGSAVE" - #261
Merged
Merged
Conversation
This reverts commit 56797ff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #260
Note
Medium Risk
Tests that use dumpAndReload during concurrent BGSAVE may flake or fail where the reverted retry logic previously absorbed the race.
Overview
Reverts the MOD-19919 behavior that retried
SAVEduringStandardEnv.dumpAndReloadwhen Redis returned Background save already in progress.dumpAndReload(non-restart path) again callssave()once per master/replica connection with no retry loop, timeout, or sleep. The_SAVE_RETRY_TIMEOUTconstant is removed.The unit tests that covered busy-save retries, timeout-without-reload, and non-retryable save errors are deleted along with related
unittest.mock/redisimports.Reviewed by Cursor Bugbot for commit 9b401f1. Bugbot is set up for automated code reviews on this repo. Configure here.