Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The parity workflow currently targets an unsynchronized OSD default branch and will fail deterministically.
Review effort: Balanced
Findings: 1
Open (3)
What changed in this PR
Unifies operating-system catalog handling across OSD and OSDCloud while adding cross-repository parity validation.
Changes:
- Consolidates OS providers while preserving module-native schemas and catalog precedence.
- Adds manifest-driven synchronization and parity checks.
- Updates HP date parsing, module version, and release documentation.
| File | Description |
|---|---|
README.md |
Updates module version. |
OSDCloud/private/Update-OSDCloudCoreCatalogOS.ps1 |
Expands maintenance notes. |
OSDCloud/private/Initialize-DeployOSDCloud.ps1 |
Uses unified OS provider. |
OSDCloud/private/core-operatingsystem/Set-OSDCoreOperatingSystemCloudObject.ps1 |
Unifies provider selection. |
OSDCloud/private/core-operatingsystem/Initialize-ModuleCoreOperatingSystems.ps1 |
Prefers bundled catalogs on revision ties. |
OSDCloud/private/core-operatingsystem/Get-OSDCoreOperatingSystems.ps1 |
Produces module-native schemas. |
OSDCloud/private/core-operatingsystem/Get-OSDCloudCoreOperatingSystems.ps1 |
Removes redundant provider. |
OSDCloud/private/core-operatingsystem/dev/Get-OSDCloudDefaultOS.ps1 |
Migrates default selection. |
OSDCloud/private/core-driverpack/Get-OSDCoreDriverPackCatalogHP.ps1 |
Uses invariant date parsing. |
OSDCloud/OSDCloud.psd1 |
Updates version and description. |
CHANGELOG.md |
Documents release changes. |
.github/workflows/check-osd-operating-system-parity.yaml |
Adds parity workflow. |
.github/skills/osdcore-operating-system-cloud-object/SKILL.md |
Updates provider guidance. |
.github/scripts/Sync-OSDOperatingSystemParity.ps1 |
Adds synchronization checker. |
.github/scripts/osd-operating-system-sync.json |
Defines synchronized paths. |
.github/instructions/osdcloud-catalog-update.instructions.md |
Updates maintenance guidance. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| - name: Checkout OSD | ||
| uses: actions/checkout@v5 | ||
| with: | ||
| repository: OSDeploy/OSD |
Comment on lines
+96
to
+98
| if (-not (Test-Path -LiteralPath $destinationDirectory -PathType Container) -and -not $Check) { | ||
| $null = New-Item -Path $destinationDirectory -ItemType Directory -Force | ||
| } |
Comment on lines
+9
to
+10
| workflows. OSD receives its existing public property schema, while OSDCloud receives | ||
| its native OS-prefixed property schema. The function derives build identity, Windows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
26.9.30.1Validation
Test-ModuleManifestand release-document version consistency checks