Conversation
…nstallation tasks
… post-installation tasks
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The setup script directory is not created before writing command files, and several documented release lists omit the still-supported 23H2 option.
Review effort: Balanced
Findings: 1
Open (6)
What changed in this PR
Adds Windows 11 26H2 deployment support and makes it the default release across OSDCloud workflows.
Changes:
- Adds 26H2 catalog mapping and selection defaults.
- Initializes post-installation command files and updates driver handling.
- Updates module metadata, UI, documentation, and maintenance guidance.
| File | Description |
|---|---|
README.md |
Updates version and default OS. |
OSDCloud/workflow/default/ux/MainWindow.xaml |
Updates displayed default media. |
OSDCloud/workflow/default/os-arm64.json |
Adds and defaults ARM64 26H2. |
OSDCloud/workflow/default/os-amd64.json |
Adds and defaults amd64 26H2. |
OSDCloud/workflow/cli/os-arm64.json |
Adds CLI ARM64 26H2. |
OSDCloud/workflow/cli/os-amd64.json |
Adds CLI amd64 26H2. |
OSDCloud/private/steps/5-drivers/step-Save-WindowsDriver-DriverPack.ps1 |
Updates generated script branding. |
OSDCloud/private/steps/4-install/step-install-expandwindowsimage.ps1 |
Initializes post-install command files. |
OSDCloud/private/microsoft-update-catalog/Save-MicrosoftUpdateCatalogDriver.ps1 |
Prioritizes 26H2 driver searches. |
OSDCloud/private/core-operatingsystem/Set-OSDCoreOperatingSystemCloudObject.ps1 |
Defaults OS selection to 26H2. |
OSDCloud/private/core-operatingsystem/ConvertTo-OSDCoreOperatingSystemInfo.ps1 |
Maps build 26300 to 26H2. |
OSDCloud/private/core-cache/Update-RecastOSDCloudUSBCache.ps1 |
Supports and defaults cached 26H2 media. |
OSDCloud/OSDCloud.psd1 |
Updates module version and description. |
docs/07-arm64-devices.md |
Updates ARM64 release documentation. |
docs/05-customize-deployment.md |
Updates workflow customization examples. |
docs/04-deploy-windows.md |
Updates deployment defaults. |
docs/01-overview.md |
Updates supported-release overview. |
CHANGELOG.md |
Documents the release. |
.github/instructions/workflow-tasks.instructions.md |
Updates workflow configuration guidance. |
.github/instructions/osdcloud-catalog-update.instructions.md |
Updates catalog maintenance guidance. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+56
to
+59
| $setupCompletePath = 'C:\Windows\Setup\Scripts\SetupComplete.cmd' | ||
| if (-not (Test-Path $setupCompletePath)) { | ||
| New-Item -Path $setupCompletePath -ItemType File -Force | Out-Null | ||
| } |
Comment on lines
+159
to
+160
| "default": "Windows 11 26H2", | ||
| "values": ["Windows 11 26H2", "Windows 11 25H2", "Windows 11 24H2"] |
| | Deploy a custom corporate gold image | **No** — OSDCloud uses Microsoft ESDs. Use MDT/ConfigMgr or build a custom WIM. | | ||
| | Air-gapped network (no internet) | **No** — OSDCloud downloads ESDs and driver packs at runtime. | | ||
| | Deploy Windows 10 | **No** — current workflows target Windows 11 (25H2/24H2/23H2). | | ||
| | Deploy Windows 10 | **No** — current workflows target Windows 11 (26H2/25H2/24H2). | |
| | Setting | Default | Notes | | ||
| |---|---|---| | ||
| | Operating System | Windows 11 25H2 | 24H2 and 23H2 also available | | ||
| | Operating System | Windows 11 26H2 | 25H2 and 24H2 also available | |
Comment on lines
+18
to
19
| Its settings allow Windows 11 26H2, 25H2, and 24H2 and use the standard | ||
| 40-step task. |
| | Setting | Default | Available values | | ||
| |---|---|---| | ||
| | Operating System | Windows 11 25H2 | 25H2, 24H2, 23H2 | | ||
| | Operating System | Windows 11 26H2 | 26H2, 25H2, 24H2 | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
git diff --check