Skip to content

Declare the minimum supported Rust version and check it in CI - #53

Open
LucaCappelletti94 wants to merge 3 commits into
RPG-Alex:mainfrom
LucaCappelletti94:chore/declare-msrv
Open

LucaCappelletti94 wants to merge 3 commits into
RPG-Alex:mainfrom
LucaCappelletti94:chore/declare-msrv

Conversation

@LucaCappelletti94

Copy link
Copy Markdown
Contributor

The crate has no rust-version, so there is no stated minimum Rust and nothing checks one.

By bisection, it turns out that it is 1.88 in practice, as cargo +1.88.0 check builds both feature sets, cargo +1.87.0 check fails.

This PR adds an msrv job that runs cargo check and cargo check --no-default-features on 1.88.0 so the declared value is verified.

@codacy-production

codacy-production Bot commented Sep 17, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@codecov

codecov Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@LucaCappelletti94
LucaCappelletti94 marked this pull request as ready for review September 17, 2026 12:28

@codacy-production codacy-production Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

The PR establishes a Minimum Supported Rust Version (MSRV) of 1.88 and introduces a dedicated CI workflow to enforce this compatibility. Codacy analysis indicates the changes are up to standards.

While the implementation meets the primary acceptance criteria, the CI check is currently insufficient to prevent MSRV drift in feature-gated code or test-specific dependencies. Specifically, the workflow lacks verification for all feature combinations and non-library targets, which often introduce higher Rust version requirements through transitive dependencies or new language features.

Test suggestions

  • Verify the project compiles on the declared MSRV (1.88) with default features.
  • Verify the project compiles on the declared MSRV (1.88) with no-default features.
  • Verify the project compiles on the declared MSRV (1.88) with all features enabled.
  • Verify all targets (tests, examples, benchmarks) compile on the declared MSRV (1.88).
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify the project compiles on the declared MSRV (1.88) with all features enabled.
2. Verify all targets (tests, examples, benchmarks) compile on the declared MSRV (1.88).

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

Comment thread .github/workflows/rust.yml Outdated
Co-authored-by: codacy-production[bot] <61871480+codacy-production[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant