Clippy fixes - #52
Clippy fixes#52
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Pull Request Overview
This PR aligns the codebase with Rust idiomatic standards by refactoring assertions and simplifying lifetime declarations. The changes are up to project standards and pass static analysis. A gap was identified regarding the automated verification of the SqlDocBuilder implementation in no_std environments; while the code is updated, the corresponding test scenario is not present in the current suite to verify correctness for that specific target.
Test suggestions
- Verify that test_comments in src/comments.rs correctly validates the length of the comments vector with the updated assertion.
- Verify that SqlDocBuilder::build for no_std targets correctly resolves lifetimes and constructs SqlDoc as expected.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that SqlDocBuilder::build for no_std targets correctly resolves lifetimes and constructs SqlDoc as expected.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
|
@RPG-Alex do check this PR out when you get a chance. |
|
This makes sense. Thanks for the changes |
I will be sending a few PRs stacked on top of this one to complete the upgrade to sqlparser 63, which should finally allow us to publish sql-traits and a lot of what depends on it.