Skip to content

Clippy fixes - #52

Merged
RPG-Alex merged 1 commit into
RPG-Alex:mainfrom
LucaCappelletti94:fix/clippy-on-main
Sep 17, 2026
Merged

RPG-Alex merged 1 commit into
RPG-Alex:mainfrom
LucaCappelletti94:fix/clippy-on-main

Conversation

@LucaCappelletti94

Copy link
Copy Markdown
Contributor

I will be sending a few PRs stacked on top of this one to complete the upgrade to sqlparser 63, which should finally allow us to publish sql-traits and a lot of what depends on it.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@codecov

codecov Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@LucaCappelletti94
LucaCappelletti94 marked this pull request as ready for review September 15, 2026 13:42
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-15T13:44:27.409443Z b922fbb Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codacy-production codacy-production Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aligns the codebase with Rust idiomatic standards by refactoring assertions and simplifying lifetime declarations. The changes are up to project standards and pass static analysis. A gap was identified regarding the automated verification of the SqlDocBuilder implementation in no_std environments; while the code is updated, the corresponding test scenario is not present in the current suite to verify correctness for that specific target.

Test suggestions

  • Verify that test_comments in src/comments.rs correctly validates the length of the comments vector with the updated assertion.
  • Verify that SqlDocBuilder::build for no_std targets correctly resolves lifetimes and constructs SqlDoc as expected.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that SqlDocBuilder::build for no_std targets correctly resolves lifetimes and constructs SqlDoc as expected.

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

@LucaCappelletti94

Copy link
Copy Markdown
Contributor Author

@RPG-Alex do check this PR out when you get a chance.

@RPG-Alex

Copy link
Copy Markdown
Owner

This makes sense. Thanks for the changes

@RPG-Alex
RPG-Alex merged commit 93c9b6c into RPG-Alex:main Sep 17, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants