[CP 1688] Add Makefile var to override dev.env file - #660
Merged
spraveenio merged 2 commits intoSep 29, 2026
Merged
spraveenio merged 2 commits into
spraveenio merged 2 commits into
Conversation
Signed-off-by: Landon LaSmith <LLaSmith@redhat.com> (cherry picked from commit f56401cbc87c51334248ce1853b6eaa60932d2d6)
spraveenio
approved these changes
Sep 29, 2026
spraveenio
left a comment
spraveenio
left a comment
Collaborator
There was a problem hiding this comment.
looks straightforward. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cp of pensando/gpu-operator#1688
Source PR Description (pensando/gpu-operator#1688):
This is a small QOL change to support specifying a custom file instead of using
dev.envwhen runningmake <target>. This will make it easier to deploy into user custom development/staging environments while preserving a defaultdev.envfile.VALIDATION
make <TARGET>works without any errorsdev.envrun without errorsmake DEV_ENV_FILE=fooworks with values specified in filefooCherrypick triggered by: ACP-Automation