Repository navigation
docs: GUI walkthrough installs from the lineforge repo - #44
Merged
Merged
Conversation
The walkthrough told people to clone RFingAdam/lineforge-gui, which does not exist (the GUI was merged into lineforge under frontend/ and src/lineforge/web/), so anyone who registers that name could serve code to readers. Describe the current setup: pip install -e ".[gui]" and lineforge gui.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
examples/08_gui_walkthrough.mdtold readers togit clone https://github.com/RFingAdam/lineforge-guiand set up a separate backend venv and frontend there. That repo does not exist (the GUI was merged into lineforge itself, underfrontend/andsrc/lineforge/web/), so the instructions fail today and would fetch whatever code someone later puts at that name.Changes:
lineforge.webbackend,frontend/Next.js app).RFingAdam/lineforgeandpip install -e ".[gui]"(with the Rust toolchain note from the README), plus Node and pnpm on PATH. The separate backend venv and manualpnpm installsteps are gone becauselineforge guihandles the frontend deps.lineforge guiinsrc/lineforge/cli.pydoes now (checksfrontend/, installsnode_modulesif missing, runsuvicorn lineforge.web.app:appandpnpm dev, moves to a free port if busy).Checked:
lineforge-gui: the only hit left is the private npm package namelineforge-gui-frontendinfrontend/package.json, which is not a URL.guicommand insrc/lineforge/cli.py, theguiextra inpyproject.toml, and thedev/startscripts infrontend/package.json. Tool names in the walkthrough (set_geometry_type,set_geometry_field,target_z0) still exist insrc/lineforge/web/agent.py.examples/08_gui_walkthrough.mdis touched.