Skip to content

ci: adopt the hardened shared risk gate - #105

Merged
Pigbibi merged 1 commit into
mainfrom
governance/gate-hardening
Nov 5, 2026
Merged

Pigbibi merged 1 commit into
mainfrom
governance/gate-hardening

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator

AI assistance

Qoder agent (DeepSeek) prepared the change and ran the local checks. Codex reviews through the repository integration.

What changed

.github/workflows/risk-gate.yml now matches the file adopted by .github#46 and QuantAIService#475 (sha256 701918c57d6194e10f110ac987f8a4b937ddc17989fb271cced03907392ce322), with two hardening fixes:

  • Receipt selection reads the newest marker-bearing Codex comment before validating it, ordered by updated_at and then by descending comment id, so a malformed, duplicated or blocking newer receipt cannot fall back to an older clean one.
  • The high-risk classifier keeps .github/governance/, ai_service, aiservice, kelly, stop_loss, release, service_account, permission, role_binding, k8s, kubernetes, and .pem/.key/.p12/.pfx files in the clearing-label tier.

Nothing else changes: same triggers, same record_label head/event binding, same contexts, same permissions.

How verified

  • sha256 of the committed file equals the reference above.
  • actionlint 1.7.12 exits 0.
  • Ten receipt-selection cases and eighteen classification cases run locally against the embedded workflow function.
  • The gate on this repository's default branch is the same design, so this pull request is evaluated normally.

Why

Twenty-six repositories carried three different gate files. One file, with the two fixes Codex found on the unification pull requests, removes the divergence and keeps the organisation on a single implementation.

Risk

High: the change touches .github/workflows/. The observable difference is a wider high-risk classifier, so a pull request touching release, permission, service-account or Kubernetes paths now needs a head-bound clearing label where it did not before. No secret, token, label write, merge or deploy is added.

One gate file for every QuantStrategyLab repository, with the receipt-selection
and high-risk classification fixes Codex found on the unification pull requests.
@Pigbibi

Pigbibi commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-05T19:08:43.715546Z 22f9e16 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 22f9e16444

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Pigbibi
Pigbibi marked this pull request as ready for review November 5, 2026 19:07
@Pigbibi Pigbibi added the agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation label Nov 5, 2026
@Pigbibi
Pigbibi merged commit 43db79c into main Nov 5, 2026
14 of 16 checks passed
@Pigbibi
Pigbibi deleted the governance/gate-hardening branch November 5, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant