Repository navigation
docs: define the paper trading minimum observation period - #770
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
Pigbibi
added
the
owner-approved
Pigbibi
marked this pull request as ready for review
November 2, 2026 18:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI assistance
Codex (GPT-6); exact model variant was not exposed in this job.
What changed
Add "Paper-trading minimum observation period" to the Chinese strategy promotion risk standard. Count only completed whole sessions of the relevant exchange calendar; exclude partial, half-day, aborted and closed holiday/weekend sessions. Accept only explicitly configured integers 3 through 5; recommend 5. Missing, unreadable or invalid settings mean the gate is not satisfied, even after five observed sessions. Reject bools and numeric coercion.
This is a written rule only. Repository inspection found no natural consumer for a universal Paper minimum: candidate forward-observation policies are explicitly frozen per candidate, release readiness binds artifacts, and the legacy shadow performance proxy is not a Paper go-live gate. No constant, config key, schema, validator or counting subsystem is added.
How verified
python3 scripts/check_style.py: exit 0; zero blocking findings and one existing README advisory.git diff --check: passed.Why
The owner explicitly authorized a 3–5 trading-day Paper observation minimum on 2026-11-03 at 02:06 SGT. The previous investigation found no canonical universal gate to edit; this adds the newly authorized written rule rather than claiming to modify an existing machine gate.
Risk
Risk-control document: owner approval via the
owner-approvedlabel is required before merge. This job does not add that label. Review and merge belong to the established code-review-and-merge bot; this PR must remain Draft pending that process.A shorter observation sample may miss operational faults or market regimes. The minimum remains necessary but insufficient: clean reconciliation, resolved alerts, unchanged and passing risk checks, and a separate owner decision on the website are required. Live trading, Kelly and every stop-loss switch, including
PORTFOLIO_LOSS_STOPLOSS_ENABLED, remain OFF; no switch is changed here. Candidate-specific research/forward windows, including the SOXL 252-session example, are unchanged and cannot be overridden by the 3–5-day rule. No deployment or runtime adoption is performed.