Repository navigation
fix: propagate CN strategy retirement policy - #90
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Pigbibi
commented
Nov 1, 2026
Pigbibi
left a comment
Contributor
Author
There was a problem hiding this comment.
Self-review of the current PR head after CI passed: no blocking findings.
- The CN dependency uses the current empty rollout allowlist, including removal of the optional aggressive profile. QPK matches the strategy package requirement; no other dependency version changed.
- Registry, loader, environment settings, preflight and HTTP tests reject retired selection. Historical metadata and adapter lookup remain available.
- The historical policy fixture is opt-in for offline risk/preflight contract tests only; retirement tests use the real policy. Existing concentration and non-dry-run protections remain asserted.
- Python 3.12 CI passed all 47 tests plus lint. Documentation and secret scanning passed. Local pytest could not complete because native module loading stalled.
- No workflow, deployment, IAM, secret, runtime-target or live-trading change. This is an implementation self-review, not an independent reviewer approval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI assistance
OpenAI Codex (GPT-6). Implementation and self-review by the same assistant.
What changed
Pin CnEquityStrategies to the current retirement policy and align QPK with its declared dependency. The QMT allowlist is empty: both industry ETF variants and their aliases are rejected before execution. Keep historical catalog metadata and adapters; retain offline risk and preflight contract tests through an explicit test-only historical policy fixture.
Update regression tests and English/Chinese usage documentation. This change does not deploy or change runtime targets, IAM, secrets, or live trading settings.
How verified
uv.lock; only the intended shared dependency revisions changed.