Skip to content

fix: propagate CN strategy retirement policy - #90

Merged
Pigbibi merged 1 commit into
mainfrom
fix/propagate-hk-cn-retirement-policy
Nov 1, 2026
Merged

Pigbibi merged 1 commit into
mainfrom
fix/propagate-hk-cn-retirement-policy

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

AI assistance

OpenAI Codex (GPT-6). Implementation and self-review by the same assistant.

What changed

Pin CnEquityStrategies to the current retirement policy and align QPK with its declared dependency. The QMT allowlist is empty: both industry ETF variants and their aliases are rejected before execution. Keep historical catalog metadata and adapters; retain offline risk and preflight contract tests through an explicit test-only historical policy fixture.

Update regression tests and English/Chinese usage documentation. This change does not deploy or change runtime targets, IAM, secrets, or live trading settings.

How verified

  • Inspected the old and new upstream allowlists and dependency source changes.
  • Regenerated uv.lock; only the intended shared dependency revisions changed.
  • CI on Python 3.12: all 47 tests passed; ruff, documentation, commit convention and Gitleaks checks passed. CI run.
  • Local ruff and documentation checks passed. Local pytest stalled during native module loading on macOS; test acceptance is based on the successful Linux CI run.
  • Retirement regressions cover canonical selection, aliases, direct loaders, and retained historical metadata/adapters. Existing selection expectations now require rejection.
  • Deployment workflow triggers were inspected: this PR and merge do not dispatch deployment.

Co-Authored-By: Codex <noreply@openai.com>
@coderabbitai

coderabbitai Bot commented Nov 1, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 10a6ae05-775a-4def-8169-27b3ccd4ba9e
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@Pigbibi Pigbibi left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review of the current PR head after CI passed: no blocking findings.

  • The CN dependency uses the current empty rollout allowlist, including removal of the optional aggressive profile. QPK matches the strategy package requirement; no other dependency version changed.
  • Registry, loader, environment settings, preflight and HTTP tests reject retired selection. Historical metadata and adapter lookup remain available.
  • The historical policy fixture is opt-in for offline risk/preflight contract tests only; retirement tests use the real policy. Existing concentration and non-dry-run protections remain asserted.
  • Python 3.12 CI passed all 47 tests plus lint. Documentation and secret scanning passed. Local pytest could not complete because native module loading stalled.
  • No workflow, deployment, IAM, secret, runtime-target or live-trading change. This is an implementation self-review, not an independent reviewer approval.

@Pigbibi Pigbibi added the owner-approved Owner approval for high-risk PRs. AI agents must never apply this label. label Nov 1, 2026
@Pigbibi
Pigbibi merged commit ae2060a into main Nov 1, 2026
8 of 10 checks passed
@Pigbibi
Pigbibi deleted the fix/propagate-hk-cn-retirement-policy branch November 1, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

owner-approved Owner approval for high-risk PRs. AI agents must never apply this label.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant