Repository navigation
feat: Wire disabled plain-DCA PAPER scheduler previews - #712
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com> # Conflicts: # docs/runtime-target-manifest.md
Co-Authored-By: Codex <noreply@openai.com> # Conflicts: # docs/runtime-target-manifest.md
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
Pigbibi
marked this pull request as ready for review
November 5, 2026 20:35
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Pigbibi
added
the
agent-approved
ChatGPT Codex Connector
This was referenced Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI assistance
Codex (host-configured model; exact variant unavailable).
What changed
Add a disabled-by-default scheduler hook that connects injected frozen inputs to the existing Phase 1 preview consumer. Disabled ticks perform no binding or fact reads. Enabled offline ticks validate paper admission before reading facts and re-read the protected binding afterward. Preserve preview-only output; refuse malformed flags, SG/unknown safety, stale bindings, reader failures and changed admission.
How verified
139 focused scheduler/dependency/adapter/readback/installed-version/V7 tests and 11 subtests passed on the synchronized branch. This includes both families through the real installed UES API, unchanged frozen inputs/tranche, repeat previews, no reads while disabled, SG/safety/staleness rejection and admission drift after facts. Ruff, documentation style (0 blocking; existing README advisory), whitespace and redacted Gitleaks passed. Hosted CI and exact-head review remain separate.
Why
A scheduler integration must retain the paper-only guard and must not turn the pure UES preview into trading authority.
Risk
Owner t1270u: engineering only. The hook remains disabled. No timer, cron, HTTP route or cloud scheduler job is provisioned or enabled; host trigger activation, authoritative protected reader, frozen runtime facts and durable order execution remain separate prerequisites. No synthetic runtime fallback, period claim, order, notification, PAPER start, deployment, Secrets/IAM, DEFAULT_SPEC or #707 operation. Starting PAPER requires the owner's separate card. This Draft wires the preview call boundary, not a deployed trading scheduler.