Repository navigation
feat: Observe protected plain-DCA PAPER configuration - #711
Conversation
Co-Authored-By: Codex <noreply@openai.com>
|
@codex review Exact-head review requested by owner t1270u. Check protected read-only scope, SG rejection, alias/duplicate/serving-drift handling and redaction. This preparatory reader explicitly returns partial/unknown and paper_start_ready=false: there is no authoritative Kelly/all-stop-loss source or independent broker credential identity proof yet. No deployment, PAPER start, scheduler enablement, Secrets/IAM, DEFAULT_SPEC or #707 operations. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Pigbibi
added
the
agent-approved
ChatGPT Codex Connector
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d0765864d3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Pigbibi
removed
the
agent-approved
Co-Authored-By: Codex <noreply@openai.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5c9faaddba
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Codex <noreply@openai.com>
Pigbibi
added
the
agent-approved
ChatGPT Codex Connector
AI assistance
Codex (host-configured model; exact variant unavailable).
What changed
Add a plain-dca mode to the existing protected PAPER metadata workflow. Validate the fixed paper manifest target, disabled protected binding and physical-account expectation before cloud authentication. Read only service/revision metadata; compare every serving revision and reject alias conflicts, duplicate keys, missing bindings and drift. Emit only fixed diagnostics and comparison results.
How verified
239 focused readback/adapter/configuration-precedence tests and 11 subtests passed after the review fixes. Read the physical-account binding from the existing protected variable contract, and reject conflicting/unresolved QSL target/enablement/dry-run aliases in the observer and preview adapter. Repository Ruff, documentation style (0 blocking; existing README advisory), whitespace and redacted Gitleaks passed. Hosted full-suite CI passed on the exact head. Local full suite: 3059 passed, 15 failed, 3 skipped; the identical 15 failures were reproduced on untouched main in the same macOS environment (35 selected cases: 20 passed, 15 failed, 80 subtests passed). The affected baseline files are unchanged. No baseline checks or assertions were weakened.
Why
The Phase 1 adapter needs authentic configuration evidence. An injected unit fixture cannot establish the deployed target or account binding.
Risk
Owner t1270u: engineering and read-only observation only. This is deliberately partial: the runtime has no authoritative Kelly/all-stop-loss reader, so those fields remain null, broker credential identity remains unverified, paper_start_ready stays false and the observation exits with failure. Explicit durable-live-command false is reported separately from global Live OFF. Do not turn missing values into false, invent evidence switches, or change protected configuration to make it pass. No Secret Manager resolution, application/broker invocation, cloud mutation, PAPER start, scheduler activation, DEFAULT_SPEC or #707 work. Deployment and owner start-card prerequisites remain unfulfilled.