Repository navigation
feat: Adopt the installed UES plain-DCA preview contract - #710
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
Collaborator
Author
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com> # Conflicts: # docs/runtime-target-manifest.md
Pigbibi
marked this pull request as ready for review
November 5, 2026 20:29
This was referenced Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI assistance
Codex (host-configured model; exact variant unavailable).
What changed
Adopt the merged plain-DCA UES revision in pyproject.toml, uv.lock and qsl.toml. Keep the existing QPK override and other dependency pins. Add synthetic tests for installed revision provenance, both baseline families, exact final tranche, repeat previews, fail-closed missing facts, real Phase 1 adapter consumption and SG refusal. Update the existing runtime contract.
How verified
Frozen installation, 55 focused dependency/installed-version/V7 tests, repository Ruff, uv lock check, installed UES provenance checker, documentation style (0 blocking; existing README advisory), diff whitespace and redacted Gitleaks passed. Hosted CI is checked separately on the final reviewed head.
Why
The previous installed UES pin cannot supply plain_dca, leaving the Phase 1 consumer unavailable. Use the adjacent merged feature revision rather than unrelated newer strategy changes.
Risk
Engineering prerequisite only under owner t1270u. No PAPER start, deployment, order writer, scheduler activation, Secrets/IAM, DEFAULT_SPEC or #707 changes. Installed adoption does not establish deployed package adoption, broker identity, safety-switch readback or runtime isolation. V7's original approved UES revision is unchanged: its admission rejects this new installed revision, covered by a real-installed-package regression. The existing paused identity-shape test uses its original approved revision as a synthetic fixture; no production approval constant or candidate is broadened. Exact-head Codex review and required checks are required before agent-approved merge.